Skip to content

Commit f67a3d1

Browse files
pchilamergify[bot]
authored andcommitted
Comment out check for ms_tls13kdf tag for FIPS-capable binaries (#10148)
(cherry picked from commit cb9c826)
1 parent 7852cba commit f67a3d1

File tree

1 file changed

+7
-1
lines changed

1 file changed

+7
-1
lines changed

dev-tools/packaging/testing/package_test.go

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -844,7 +844,13 @@ func checkFIPS(t *testing.T, agentPackageRootDir string) {
844844
case "-tags":
845845
foundTags = true
846846
require.Contains(t, setting.Value, "requirefips")
847-
require.Contains(t, setting.Value, "ms_tls13kdf")
847+
// the check on ms_tls13kdf is no longer needed for go >= 1.25
848+
// It should probably be conditioned to the output of `go version <binary>`
849+
// for example:
850+
// go version elastic-agent-9.2.0-SNAPSHOT-linux-x86_64/data/elastic-agent-7b3817/components/apm-server
851+
// elastic-agent-9.2.0-SNAPSHOT-linux-x86_64/data/elastic-agent-7b3817/components/apm-server: go1.25.1
852+
//
853+
// require.Contains(t, setting.Value, "ms_tls13kdf")
848854
continue
849855
case "GOEXPERIMENT":
850856
foundExperiment = true

0 commit comments

Comments
 (0)