Skip to content

Commit 6c47c2a

Browse files
mergify[bot]pchila
andauthored
Comment out check for ms_tls13kdf tag for FIPS-capable binaries (#10148) (#10149)
(cherry picked from commit cb9c826) Co-authored-by: Paolo Chilà <[email protected]>
1 parent 77955e7 commit 6c47c2a

File tree

1 file changed

+7
-1
lines changed

1 file changed

+7
-1
lines changed

dev-tools/packaging/testing/package_test.go

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -742,7 +742,13 @@ func checkFIPS(t *testing.T, agentPackageRootDir string) {
742742
case "-tags":
743743
foundTags = true
744744
require.Contains(t, setting.Value, "requirefips")
745-
require.Contains(t, setting.Value, "ms_tls13kdf")
745+
// the check on ms_tls13kdf is no longer needed for go >= 1.25
746+
// It should probably be conditioned to the output of `go version <binary>`
747+
// for example:
748+
// go version elastic-agent-9.2.0-SNAPSHOT-linux-x86_64/data/elastic-agent-7b3817/components/apm-server
749+
// elastic-agent-9.2.0-SNAPSHOT-linux-x86_64/data/elastic-agent-7b3817/components/apm-server: go1.25.1
750+
//
751+
// require.Contains(t, setting.Value, "ms_tls13kdf")
746752
continue
747753
case "GOEXPERIMENT":
748754
foundExperiment = true

0 commit comments

Comments
 (0)