feat(heartbeat): remove deprecated certificate fields (#45572)

The tls.certificate_not_valid_before and tls.certificate_not_valid_after fields have been deprecated since 7.8.0

Author: kruskall

heartbeat/monitors/active/dialchain/tlsmeta/tlsmeta.go

@@ -75,9 +75,7 @@ func CertFields(hostCert *x509.Certificate, verifiedChains [][]*x509.Certificate
 	_, _ = x509Fields.Put("signature_algorithm", hostCert.SignatureAlgorithm.String())
 	_, _ = x509Fields.Put("public_key_algorithm", hostCert.PublicKeyAlgorithm.String())
 	_, _ = x509Fields.Put("not_before", hostCert.NotBefore)
-	_, _ = tlsFields.Put("certificate_not_valid_before", hostCert.NotBefore)
 	_, _ = x509Fields.Put("not_after", hostCert.NotAfter)
-	_, _ = tlsFields.Put("certificate_not_valid_after", hostCert.NotAfter)
 	if rsaKey, ok := hostCert.PublicKey.(*rsa.PublicKey); ok {
 		sizeInBits := rsaKey.Size() * 8
 		_, _ = x509Fields.Put("public_key_size", sizeInBits)
@@ -115,12 +113,8 @@ func CertFields(hostCert *x509.Certificate, verifiedChains [][]*x509.Certificate
 			latestChainExpiration = *chainNotAfter
 		}
 
-		// Legacy non-ECS field
-		_, _ = tlsFields.Put("certificate_not_valid_before", chainNotBefore)
 		_, _ = x509Fields.Put("not_before", chainNotBefore)
 		if chainNotAfter != nil {
-			// Legacy non-ECS field
-			_, _ = tlsFields.Put("certificate_not_valid_after", *chainNotAfter)
 			_, _ = x509Fields.Put("not_after", *chainNotAfter)
 		}
 	}

heartbeat/monitors/active/dialchain/tlsmeta/tlsmeta_test.go

@@ -114,8 +114,6 @@ func TestCertFields(t *testing.T) {
 	require.NoError(t, err)
 
 	elasticCertFields := lookslike.Strict(lookslike.MustCompile(map[string]interface{}{
-		"certificate_not_valid_after":  certNotAfter,
-		"certificate_not_valid_before": certNotBefore,
 		"server": mapstr.M{
 			"hash": mapstr.M{
 				"sha1":   "b7b4b89ef0d0caf39d223736f0fdbb03c7b426f1",
@@ -145,8 +143,6 @@ func TestCertFields(t *testing.T) {
 
 	letsEncryptCertFields := func(notBefore time.Time, notAfter time.Time) validator.Validator {
 		return lookslike.Strict(lookslike.MustCompile(map[string]interface{}{
-			"certificate_not_valid_before": notBefore,
-			"certificate_not_valid_after":  notAfter,
 			"server": mapstr.M{
 				"hash": mapstr.M{
 					"sha1":   "98d7ca35e3608b0ee7accc9ec665babdbdc6e39c",