Skip to content

Commit 8f72687

Browse files
committed
fix sonarqube bugs
1 parent e354df7 commit 8f72687

File tree

1 file changed

+17
-10
lines changed

1 file changed

+17
-10
lines changed

src/Widgets/Slider.jsx

Lines changed: 17 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -84,8 +84,11 @@ export class Slider extends Component {
8484
this.setValue(val, triggeredByUser, i);
8585
positions[i] = this.determinePosition(val);
8686
});
87-
this.setState({
88-
position: positions,
87+
this.setState((prevState) => {
88+
const positions = [...prevState.position];
89+
return {
90+
position: positions,
91+
};
8992
});
9093
} else {
9194
this.setValue(value, triggeredByUser);
@@ -211,11 +214,13 @@ export class Slider extends Component {
211214

212215
setValuePosition(value, triggeredByUser, knobIndex) {
213216
if (this.props.multiple) {
214-
const positions = [...this.state.position];
215-
positions[knobIndex] = this.determinePosition(value);
216217
this.setValue(value, triggeredByUser, knobIndex);
217-
this.setState({
218-
position: positions,
218+
this.setState((prevState) => {
219+
const positions = [...prevState.position];
220+
positions[knobIndex] = this.determinePosition(value);
221+
return {
222+
position: positions,
223+
};
219224
});
220225
} else {
221226
this.setValue(value, triggeredByUser);
@@ -227,10 +232,12 @@ export class Slider extends Component {
227232

228233
setPosition(position, knobIndex) {
229234
if (this.props.multiple) {
230-
const newPosition = [...this.state.position];
231-
newPosition[knobIndex] = position;
232-
this.setState({
233-
position: newPosition,
235+
this.setState((prevState) => {
236+
const newPosition = [...prevState.position];
237+
newPosition[knobIndex] = position;
238+
return {
239+
position: newPosition,
240+
};
234241
});
235242
} else {
236243
this.setState({

0 commit comments

Comments
 (0)