fix(deps): update babel monorepo (#25)

* fix(deps): update babel monorepo

* Update babel config option key

* fix linter in smoke test and update readme

Co-authored-by: Renovate Bot <[email protected]>
Co-authored-by: Adam Butterworth <[email protected]>

Author: 3 people

README.rst

@@ -27,7 +27,7 @@ documentation to learn what options are available. Example package.json::
      "scripts": {
         "build": "fedx-scripts webpack",
         "i18n_extract": "BABEL_ENV=i18n fedx-scripts babel src --quiet > /dev/null",
-        "lint": "fedx-scripts eslint",
+        "lint": "fedx-scripts eslint --ext .jsx,.js .",
         "precommit": "npm run lint",
         "snapshot": "fedx-scripts jest --updateSnapshot",
         "start": "fedx-scripts webpack-dev-server --progress",
@@ -113,8 +113,11 @@ or to test with an existing project you can do the following:
 1. Delete the node_modules directories in the host project:
    ``rm -rf node_modules/``
 
-2. Install the development version of frontend-build
-   ``npm i --save-dev @edx/frontend-build@file:../frontend-build``.
+2. Move frontend-build inside the host project and delete its node modules folder
+   ``mv ../frontend-build ./ && rm -rf frontend-build/node_modules``
+
+3. Install the development version of frontend-build
+   ``npm i --save-dev @edx/frontend-build@file:./frontend-build``.
 
 
 .. |Build Status| image:: https://api.travis-ci.org/edx/frontend-build.svg?branch=master

bin/fedx-scripts.js

@@ -17,7 +17,7 @@ const presets = require('../lib/presets');
  */
 
 
-function configOptionExists(keys = ['--config', '-c']) {
+function optionExists(keys) {
   return process.argv.some((arg) => {
     // eslint-disable-next-line no-plusplus
     for (let i = 0; i < keys.length; i++) {
@@ -30,10 +30,10 @@ function configOptionExists(keys = ['--config', '-c']) {
 }
 
 // Ensures that a config option already exists and if it does not adds a default
-function ensureConfigOption(preset) {
-  if (!configOptionExists()) {
+function ensureConfigOption(preset, keys = ['--config', '-c']) {
+  if (!optionExists(keys)) {
     console.log(`Running with resolved config:\n${preset.resolvedFilepath}\n`);
-    process.argv.push('--config');
+    process.argv.push(keys[0]);
     process.argv.push(preset.resolvedFilepath);
   }
 }
@@ -46,7 +46,7 @@ process.argv.splice(1, 1);
 
 switch (commandName) {
   case 'babel':
-    ensureConfigOption(presets.babel);
+    ensureConfigOption(presets.babel, ['--config-file']);
     require('@babel/cli/bin/babel');
     break;
   case 'eslint':

example/package.json

@@ -5,8 +5,8 @@
   "main": "webpack.prod.config.js",
   "scripts": {
     "test": "../bin/fedx-scripts.js jest ./src",
-    "build": "../bin/fedx-scripts.js webpack --config ./webpack.prod.config.js",
-    "lint": "../bin/fedx-scripts.js eslint .",
+    "build": "../bin/fedx-scripts.js webpack",
+    "lint": "../bin/fedx-scripts.js eslint . --ext .jsx,.js",
     "babel": "../bin/fedx-scripts.js babel src --out-dir dist/babel --source-maps --ignore **/*.test.jsx,**/*.test.js --copy-files",
     "start": "../bin/fedx-scripts.js webpack-dev-server"
   },

example/src/test.jsx renamed to example/src/App.test.jsx

@@ -1,6 +1,6 @@
 /* eslint-disable global-require */
 import React from 'react';
-import renderer, { act } from 'react-test-renderer';
+import renderer from 'react-test-renderer';
 import App from './App';
 
 describe('Basic test', () => {