Skip to content

Commit d7e4ece

Browse files
ianmcburnieianmcburnie
committed
docs: removed ARIA menu roles from navigation links
1 parent abb9709 commit d7e4ece

File tree

6 files changed

+35
-38
lines changed

6 files changed

+35
-38
lines changed

‎src/routes/_index/sitemap+page.marko‎

Lines changed: 15 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -37,51 +37,50 @@
3737
</h2>
3838

3939
<nav aria-labelledby="sitemap-pages">
40-
<ul role="menubar">
40+
<ul>
4141
<li>
4242
<a
43-
role="menuitem"
4443
href="https://github.com/eBay/evo-web/tree/main/packages/skin">
4544
Repo
4645
</a>
4746
</li>
4847
<li>
49-
<a role="menuitem" href="archive/index.html">
48+
<a href="archive/index.html">
5049
Evo CSS Archive
5150
</a>
5251
</li>
5352
<li>
5453
Storybooks
55-
<ul role="menubar">
54+
<ul>
5655
<li>
57-
<a role="menuitem" href="skin/storybook/">
56+
<a href="skin/storybook/">
5857
Evo CSS Storybook
5958
</a>
6059
</li>
6160
<li>
62-
<a role="menuitem" href="ebayui-core/">
61+
<a href="ebayui-core/">
6362
Evo Marko Storybook
6463
</a>
6564
</li>
6665
<li>
67-
<a role="menuitem" href="ebayui-core-react/main/">
66+
<a href="ebayui-core-react/main/">
6867
Evo React Storybook
6968
</a>
7069
</li>
7170
</ul>
7271
</li>
7372
<li>
74-
<a role="menuitem" href="evo-css-components">
73+
<a href="evo-css-components">
7574
Evo CSS Components
7675
</a>
7776
</li>
7877
<li>
79-
<a role="menuitem" href="evo-marko-components">
78+
<a href="evo-marko-components">
8079
Evo Marko Components
8180
</a>
8281
</li>
8382
<li>
84-
<a role="menuitem" href="evo-react-components">
83+
<a href="evo-react-components">
8584
Evo React Components
8685
</a>
8786
</li>
@@ -93,7 +92,7 @@
9392
</h2>
9493

9594
<nav aria-labelledby="sitemap-components">
96-
<ul role="menubar">
95+
<ul>
9796
<components-list/>
9897
</ul>
9998
</nav>
@@ -103,19 +102,19 @@
103102
</h2>
104103

105104
<nav aria-labelledby="sitemap-guides">
106-
<ul role="menubar">
105+
<ul>
107106
<li>
108-
<a href="guides/page-grid" role="menuitem">
107+
<a href="guides/page-grid">
109108
Page Grid Use Guide
110109
</a>
111110
</li>
112111
<li>
113-
<a href="guides/skeleton" role="menuitem">
112+
<a href="guides/skeleton">
114113
Skeleton Use Guide
115114
</a>
116115
</li>
117116
<li>
118-
<a href="guides/animation" role="menuitem">
117+
<a href="guides/animation">
119118
Animation Guide
120119
</a>
121120
</li>
@@ -127,7 +126,7 @@
127126
</h2>
128127

129128
<nav aria-labelledby="sitemap-components">
130-
<ul role="menubar">
129+
<ul>
131130
<a11y-docs-list/>
132131
</ul>
133132
</nav>

‎src/tags/a11y-docs-list.marko‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ import { a11yDocs, components, basePath } from "../data";
1515
)>
1616

1717
<li>
18-
<a href=link class="nav-link" role="menuitem">
18+
<a href=link class="nav-link">
1919
${item.properName}
2020
</a>
2121
</li>

‎src/tags/components-list.marko‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import { components } from "../data";
33
<for|_key, comp| in=components>
44
<if=comp.properName>
55
<li>
6-
<a href=(comp.componentUrls?.overview) class="nav-link" role="menuitem">
6+
<a href=(comp.componentUrls?.overview) class="nav-link">
77
${comp.properName}
88
</a>
99
</li>

‎src/tags/navrail.marko‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ export interface Input {
1515
${input.page?.toLocaleUpperCase()}
1616
</a>
1717
</h2>
18-
<ul role="menubar">
18+
<ul>
1919
<if=input.page === "components">
2020
<components-list components=components/>
2121
</if>
@@ -24,17 +24,17 @@ export interface Input {
2424
</else>
2525
<else if=input.page === "guides">
2626
<li>
27-
<a href="guides/page-grid" role="menuitem">
27+
<a href="guides/page-grid">
2828
Page Grid Use Guide
2929
</a>
3030
</li>
3131
<li>
32-
<a href="guides/skeleton" role="menuitem">
32+
<a href="guides/skeleton">
3333
Skeleton Use Guide
3434
</a>
3535
</li>
3636
<li>
37-
<a href="guides/animation" role="menuitem">
37+
<a href="guides/animation">
3838
Animation Guide
3939
</a>
4040
</li>

‎src/tags/site-footer/index.marko‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -43,12 +43,12 @@ footer class=footer role="contentinfo"
4343
li
4444
a href="guides" -- Guides
4545
li
46-
a role="menuitem" href="evo-css-components" -- Evo CSS Components
46+
a href="evo-css-components" -- Evo CSS Components
4747
li
48-
a role="menuitem" href="evo-marko-components"
48+
a href="evo-marko-components"
4949
-- Evo Marko Components
5050
li
51-
a role="menuitem" href="evo-react-components"
51+
a href="evo-react-components"
5252
-- Evo React Components
5353
li
5454
a href="sitemap" -- Sitemap

‎src/tags/site-header/index.marko‎

Lines changed: 11 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,7 @@ import { components, a11yDocs } from "../../data";
109109
</div>
110110
</a>
111111

112-
<ul class="nav__links" role="menubar">
112+
<ul class="nav__links">
113113
<li>
114114
<a href="components/" class="nav__link">
115115
Components
@@ -274,25 +274,24 @@ import { components, a11yDocs } from "../../data";
274274
id="primary-nav-mobile"
275275
class="primary-nav-mobile"
276276
aria-label="Site navigation">
277-
<ul class="app-bar__links subnav__links" role="menubar">
277+
<ul class="app-bar__links subnav__links">
278278
<li>
279-
<a role="menuitem" href="component">
279+
<a href="component">
280280
Components
281281
</a>
282282
</li>
283283
<li>
284-
<a role="menuitem" href="accessibility">
284+
<a href="accessibility">
285285
Accessibility
286286
</a>
287287
</li>
288288
<li>
289-
<a role="menuitem" href="guides">
289+
<a href="guides">
290290
Guides
291291
</a>
292292
</li>
293293
<li>
294294
<a
295-
role="menuitem"
296295
href="https://github.com/eBay/evo-web/"
297296
onBlur(event) {
298297
const relatedTarget = (event as FocusEvent)
@@ -340,10 +339,10 @@ import { components, a11yDocs } from "../../data";
340339
<nav
341340
class="accessibility-nav"
342341
aria-label="Accessibility Standards and Patterns">
343-
<ul class="subnav__links" role="menubar">
342+
<ul class="subnav__links">
344343
<li>
345344
<h3>
346-
<a href="accessibility" role="menuitem">
345+
<a href="accessibility">
347346
Accessibility Docs
348347
</a>
349348
</h3>
@@ -363,20 +362,19 @@ import { components, a11yDocs } from "../../data";
363362
<div class="tabs__cell">
364363
<nav class="examples-nav" aria-label="Guides">
365364
<ul
366-
class="modules-expander__list subnav__links"
367-
role="menubar">
365+
class="modules-expander__list subnav__links">
368366
<li>
369-
<a href="guides/page-grid" role="menuitem">
367+
<a href="guides/page-grid">
370368
Page Grid Use Guide
371369
</a>
372370
</li>
373371
<li>
374-
<a href="guides/skeleton" role="menuitem">
372+
<a href="guides/skeleton">
375373
Skeleton Use Guide
376374
</a>
377375
</li>
378376
<li>
379-
<a href="guides/animation" role="menuitem">
377+
<a href="guides/animation">
380378
Animation Guide
381379
</a>
382380
</li>

0 commit comments

Comments
 (0)