Skip to content

Commit 12860c3

Browse files
committed
Better TypeScript types for getSignal(), remove SignalOptions type (was not part of public API).
1 parent 3437fb3 commit 12860c3

File tree

8 files changed

+140
-109
lines changed

8 files changed

+140
-109
lines changed

CHANGELOG.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,6 @@
1+
### v1.0.3
2+
Better TypeScript types for `getSignal()`, remove `SignalOptions` type (was not part of public API).
3+
14
### v1.0.2
25
Better TypeScript types for `getSignal()` and `SignalOptions`.
36

package-lock.json

Lines changed: 74 additions & 74 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "ngx-reactive-storage",
3-
"version": "1.0.1",
3+
"version": "1.0.3",
44
"license": "MIT",
55
"author": {
66
"name": "Evgeniy OZ",
@@ -27,19 +27,19 @@
2727
},
2828
"private": false,
2929
"dependencies": {
30-
"@angular/core": "^17.0.1",
30+
"@angular/core": "^17.0.3",
3131
"localforage": "^1.10.0",
3232
"rxjs": "^7.8.1"
3333
},
3434
"devDependencies": {
35-
"@angular-devkit/build-angular": "^17.0.0",
36-
"@angular/cli": "^17.0.0",
37-
"@angular/compiler-cli": "^17.0.1",
38-
"@angular/platform-browser-dynamic": "^17.0.1",
35+
"@angular-devkit/build-angular": "^17.0.1",
36+
"@angular/cli": "^17.0.1",
37+
"@angular/compiler-cli": "^17.0.3",
38+
"@angular/platform-browser-dynamic": "^17.0.3",
3939
"@types/jest": "^29.5.8",
4040
"fake-indexeddb": "^5.0.1",
4141
"jest": "^29.7.0",
42-
"jest-preset-angular": "^13.1.3",
42+
"jest-preset-angular": "^13.1.4",
4343
"ng-packagr": "^17.0.0",
4444
"ts-node": "^10.9.1",
4545
"typescript": "~5.2.2"

projects/ngx-reactive-storage/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "ngx-reactive-storage",
3-
"version": "1.0.2",
3+
"version": "1.0.3",
44
"license": "MIT",
55
"private": false,
66
"author": {

projects/ngx-reactive-storage/src/lib/idb.ts

Lines changed: 16 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
1-
import { Signal } from '@angular/core';
1+
import { Signal, type ValueEqualityFn } from '@angular/core';
22
import * as localForage from 'localforage';
33
import { Observable } from 'rxjs';
44
import { Observer } from "./observer";
5-
import type { ReactiveStorage, SignalOptions } from './types';
5+
import type { ReactiveStorage } from './types';
66

77
type KeyChange = {
88
type: 'set' | 'remove';
@@ -57,8 +57,20 @@ export class RxStorage implements ReactiveStorage {
5757
return obs;
5858
}
5959

60-
getSignal<T, N = undefined>(key: string, options?: SignalOptions<T, N>): Signal<T | N> {
61-
const s = this.observer.getSignal<T, N>(key, options?.initialValue, options?.equal);
60+
getSignal<T>(key: string, options: {
61+
initialValue: T;
62+
equal?: ValueEqualityFn<T | undefined>;
63+
}): Signal<T>;
64+
65+
getSignal<T>(key: string, options?: {
66+
equal?: ValueEqualityFn<T | undefined>;
67+
}): Signal<T | undefined>;
68+
69+
getSignal<T>(key: string, options: {
70+
initialValue: T;
71+
equal?: ValueEqualityFn<T | undefined>;
72+
}): Signal<T> {
73+
const s = this.observer.getSignal<T>(key, options?.initialValue, options?.equal);
6274
this.get(key).catch();
6375
return s;
6476
}

0 commit comments

Comments
 (0)