Add minimum width and height for dialogs

Author: dyng

README.md

@@ -95,18 +95,18 @@ Ramen inherits key bindings from underlying UI framework [tview](https://github.
 [Hardhat](https://hardhat.org/) / [Ganache](https://trufflesuite.com/ganache/) provides a local Ethereum network for development purpose. Ramen can be used as an user interface for these local networks.
 
 ```shell
-./ramen -provider local
+./ramen --provider local
 ```
 
 ## Troubleshoting
 
-If you come across some problems when using Ramen, at first please check the log file `/tmp/ramen.log` to see if there are any error messages. You can also run Ramen in debug mode with command:
+If you come across some problems when using Ramen, please check the log file `/tmp/ramen.log` to see if there are any error messages. You can also run Ramen in debug mode with command:
 
 ```shell
 ramen --debug
 ```
 
-If you still can't figure out the problem, please open an issue on [GitHub](https://github.com/dyng/ramen/issues/new)
+If you still can't figure out the problem, feel free to open an issue on [GitHub](https://github.com/dyng/ramen/issues/new)
 
 ## Special Thanks
 

internal/service/contract.go

@@ -59,8 +59,8 @@ func (c *Contract) Call(method string, args ...any) ([]any, error) {
 	return c.service.provider.CallContract(c.address, c.abi, method, args...)
 }
 
-// Transact invokes a non-constant method of this contract. This will make changes to blockchain state and consume ethers.
-func (c *Contract) Transact(signer *Signer, method string, args ...any) (common.Hash, error) {
+// Send invokes a non-constant method of this contract. This method will sign and send the transaction to the network.
+func (c *Contract) Send(signer *Signer, method string, args ...any) (common.Hash, error) {
 	_, ok := c.abi.Methods[method]
 	if !ok {
 		return common.Hash{}, errors.Errorf("Method %s is not found in contract", method)

internal/view/import_abi.go

@@ -8,6 +8,13 @@ import (
 	"github.com/rivo/tview"
 )
 
+const (
+	// importABIDialogMinHeight is the minimum height of the import ABI dialog.
+	importABIDialogMinHeight = 16
+	// importABIDialogMinWidth is the minimum width of the import ABI dialog.
+	importABIDialogMinWidth  = 50
+)
+
 type ImportABIDialog struct {
 	*tview.Flex
 	app       *App
@@ -146,8 +153,11 @@ func (d *ImportABIDialog) Draw(screen tcell.Screen) {
 func (d *ImportABIDialog) SetCentral(x int, y int, width int, height int) {
 	dialogWidth := width - width/2
 	dialogHeight := height - height/2
-	if dialogHeight < 10 {
-		dialogHeight = 10
+	if dialogHeight < importABIDialogMinHeight {
+		dialogHeight = importABIDialogMinHeight
+	}
+	if dialogWidth < importABIDialogMinWidth {
+		dialogWidth = importABIDialogMinWidth
 	}
 	dialogX := x + ((width - dialogWidth) / 2)
 	dialogY := y + ((height - dialogHeight) / 2)

internal/view/method_call.go

@@ -15,6 +15,13 @@ import (
 	"github.com/rivo/tview"
 )
 
+const (
+	// methodCallDialogMinHeight is the minimum height of the method call dialog.
+	methodCallDialogMinHeight = 16
+	// methodCallDialogMinWidth is the minimum width of the method call dialog.
+	methodCallDialogMinWidth  = 80
+)
+
 type MethodCallDialog struct {
 	*tview.Flex
 	app     *App
@@ -276,7 +283,7 @@ func (d *MethodCallDialog) callMethod() {
 	if !method.IsConstant() {
 		signer = d.app.root.signer.GetSigner()
 		if signer == nil {
-			d.app.root.NotifyError(format.FineErrorMessage("Cannot call a non-constant method without a signer. Please signin at first."))
+			d.app.root.NotifyError(format.FineErrorMessage("Cannot call a non-constant method without a signer. Please signin first."))
 			return
 		}
 	}
@@ -293,8 +300,7 @@ func (d *MethodCallDialog) callMethod() {
 		if method.IsConstant() {
 			res, err = d.contract.Call(methodName, args...)
 		} else {
-			// FIXME: waiting for transaction executed
-			hash, e := d.contract.Transact(signer, methodName, args...)
+			hash, e := d.contract.Send(signer, methodName, args...)
 			res = []any{fmt.Sprintf("Transaction has been submitted to network.\n\nTxnHash: %s", hash)}
 			err = e
 		}
@@ -329,6 +335,12 @@ func (d *MethodCallDialog) SetCentral(x int, y int, width int, height int) {
 	// self
 	dialogWidth := width / 2
 	dialogHeight := height / 2
+	if dialogHeight < methodCallDialogMinHeight {
+		dialogHeight = methodCallDialogMinHeight
+	}
+	if dialogWidth < methodCallDialogMinWidth {
+		dialogWidth = methodCallDialogMinWidth
+	}
 	dialogX := x + ((width - dialogWidth) / 2)
 	dialogY := y + ((height - dialogHeight) / 2)
 	d.Flex.SetRect(dialogX, dialogY, dialogWidth, dialogHeight)

internal/view/notification.go

@@ -7,6 +7,11 @@ import (
 	"github.com/rivo/tview"
 )
 
+const (
+	// notificationMinHeight is the minimum height of the notification.
+	notificationMinHeight = 10
+)
+
 type Notification struct {
 	*tview.TextView
 	app     *App
@@ -97,8 +102,8 @@ func (n *Notification) Draw(screen tcell.Screen) {
 func (n *Notification) SetCentral(x int, y int, width int, height int) {
 	dialogWidth := width - width/3
 	dialogHeight := height / 4
-	if dialogHeight < 15 {
-		dialogHeight = 15
+	if dialogHeight < notificationMinHeight {
+		dialogHeight = notificationMinHeight
 	}
 	dialogX := x + ((width - dialogWidth) / 2)
 	dialogY := y + ((height - dialogHeight) / 2)

internal/view/transfer.go

@@ -15,6 +15,13 @@ import (
 	"github.com/rivo/tview"
 )
 
+const (
+	// transferDialogMinHeight is the minimum height of the transfer dialog.
+	transferDialogMinHeight = 10
+	// transferDialogMinWidth is the minimum width of the transfer dialog.
+	transferDialogMinWidth  = 50
+)
+
 type TransferDialog struct {
 	*tview.Form
 	app       *App
@@ -107,7 +114,7 @@ func (d *TransferDialog) doTransfer() {
 	if err != nil {
 		d.app.root.NotifyError(format.FineErrorMessage("Failed to complete transfer", err))
 	} else {
-		d.app.root.NotifyInfo(fmt.Sprintf("Transaction has been submitted. TxnHash: %s", hash))
+		d.app.root.NotifyInfo(fmt.Sprintf("Transaction has been submitted.\n\nTxnHash: %s", hash))
 	}
 }
 
@@ -151,8 +158,11 @@ func (d *TransferDialog) Draw(screen tcell.Screen) {
 func (d *TransferDialog) SetCentral(x int, y int, width int, height int) {
 	dialogWidth := width - width/2
 	dialogHeight := style.AvatarSize + 12
-	if dialogHeight < 10 {
-		dialogHeight = 10
+	if dialogHeight < transferDialogMinHeight {
+		dialogHeight = transferDialogMinHeight
+	}
+	if dialogWidth < transferDialogMinWidth {
+		dialogWidth = transferDialogMinWidth
 	}
 	dialogX := x + ((width - dialogWidth) / 2)
 	dialogY := y + ((height - dialogHeight) / 2)