Fix potential crash in TelemetryFilter when retrieving value from opt… (#50565)

Author: baronfel

src/Cli/dotnet/Extensions/ParseResultExtensions.cs

@@ -258,10 +258,20 @@ public static void HandleDebugSwitch(this ParseResult parseResult)
     }
     public static T? SafelyGetValueForOption<T>(this ParseResult parseResult, string name)
     {
-        if (parseResult.GetResult(name) is OptionResult optionResult &&
-            !parseResult.Errors.Any(e => e.SymbolResult == optionResult))
+        if (parseResult.GetResult(name) is OptionResult optionResult && // only return a value if there _is_ a value - default or otherwise
+            !parseResult.Errors.Any(e => e.SymbolResult == optionResult) // only return a value if this isn't a parsing error
+            && optionResult.Option.ValueType.IsAssignableTo(typeof(T))) // only return a value if coercing the type won't error
         {
-            return optionResult.GetValue<T>(name);
+            // shouldn't happen because of the above checks, but we can be safe since this is only used in telemetry, and should
+            // be resistant to errors
+            try
+            {
+                return optionResult.GetValue<T>(name);
+            }
+            catch
+            {
+                return default;
+            }
         }
         else
         {