Reverse order of loop in MightHaveInterfaceDispatchMap

filipnavara · filipnavara · commit 924c611e249b · 2024-06-05T09:50:00.000+02:00
Presumably the last interfaces on the list are more likely to be coming
from the less nested classes and allow short circuiting the loop earlier.
diff --git a/src/coreclr/tools/aot/ILCompiler.Compiler/Compiler/DependencyAnalysis/InterfaceDispatchMapNode.cs b/src/coreclr/tools/aot/ILCompiler.Compiler/Compiler/DependencyAnalysis/InterfaceDispatchMapNode.cs
@@ -89,7 +89,7 @@ public static bool MightHaveInterfaceDispatchMap(TypeDesc type, NodeFactory fact
 
             DefType declType = type.GetClosestDefType();
 
-            for (int interfaceIndex = 0; interfaceIndex < declType.RuntimeInterfaces.Length; interfaceIndex++)
+            for (int interfaceIndex = declType.RuntimeInterfaces.Length - 1; interfaceIndex >= 0; interfaceIndex--)
             {
                 DefType interfaceType = declType.RuntimeInterfaces[interfaceIndex];
                 InstantiatedType interfaceOnDefinitionType = interfaceType.IsTypeDefinition ?

Original file line number	Diff line number	Diff line change
`@@ -89,7 +89,7 @@ public static bool MightHaveInterfaceDispatchMap(TypeDesc type, NodeFactory fact`
`89`	`89`
`90`	`90`	`DefType declType = type.GetClosestDefType();`
`91`	`91`
`92`		`- for (int interfaceIndex = 0; interfaceIndex < declType.RuntimeInterfaces.Length; interfaceIndex++)`
	`92`	`+ for (int interfaceIndex = declType.RuntimeInterfaces.Length - 1; interfaceIndex >= 0; interfaceIndex--)`
`93`	`93`	`{`
`94`	`94`	`DefType interfaceType = declType.RuntimeInterfaces[interfaceIndex];`
`95`	`95`	`InstantiatedType interfaceOnDefinitionType = interfaceType.IsTypeDefinition ?`