Fix the encoding for sve_mov (#114244)

kunalspathak · web-flow · commit 14fb8d69a685 · 2025-04-03T21:51:45.000-07:00
My #113860 exposed a bug in encoding of sve_mov, where we were wrongly skipping the encoding the Zm field and giving wrong instruction. Fixes: #113939
diff --git a/src/coreclr/jit/emitarm64sve.cpp b/src/coreclr/jit/emitarm64sve.cpp
@@ -10394,6 +10394,10 @@ BYTE* emitter::emitOutput_InstrSve(BYTE* dst, instrDesc* id)
             {
                 code |= insEncodeReg_V<20, 16>(id->idReg3()); // mmmmm
             }
+            else
+            {
+                code |= insEncodeReg_V<20, 16>(id->idReg2()); // mmmmm
+            }
             dst += emitOutput_Instr(dst, code);
             break;
 

Original file line number	Diff line number	Diff line change
`@@ -10394,6 +10394,10 @@ BYTE* emitter::emitOutput_InstrSve(BYTE* dst, instrDesc* id)`
`10394`	`10394`	`{`
`10395`	`10395`	`code \|= insEncodeReg_V<20, 16>(id->idReg3()); // mmmmm`
`10396`	`10396`	`}`
	`10397`	`+ else`
	`10398`	`+ {`
	`10399`	`+ code \|= insEncodeReg_V<20, 16>(id->idReg2()); // mmmmm`
	`10400`	`+ }`
`10397`	`10401`	`dst += emitOutput_Instr(dst, code);`
`10398`	`10402`	`break;`
`10399`	`10403`