Skip to content

Commit 2527e68

Browse files
authored
Merge pull request #4905 from TIHan/perf-fixes1-dev15.7
Removed updating project info on document open and document changed - For dev15.7 branch
2 parents d3f0242 + c30b3f5 commit 2527e68

File tree

1 file changed

+3
-6
lines changed

1 file changed

+3
-6
lines changed

vsintegration/src/FSharp.Editor/LanguageService/LanguageService.fs

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -57,10 +57,10 @@ type internal FSharpCheckerProvider
5757
let mmd = amd.GetModules().[0]
5858
let mmr = mmd.GetMetadataReader()
5959

60-
// "lifetime is timed to Metadata you got from the GetMetadata(…). As long as you hold it strongly, raw
60+
// "lifetime is timed to Metadata you got from the GetMetadata(…). As long as you hold it strongly, raw
6161
// memory we got from metadata reader will be alive. Once you are done, just let everything go and
6262
// let finalizer handle resource rather than calling Dispose from Metadata directly. It is shared metadata.
63-
// You shouldn’t dispose it directly."
63+
// You shouldn’t dispose it directly."
6464

6565
let objToHold = box md
6666

@@ -425,7 +425,6 @@ type internal FSharpLanguageService(package : FSharpPackage) =
425425
member private this.OnProjectAdded(projectId:ProjectId) = projectInfoManager.UpdateProjectInfoWithProjectId(projectId, "OnProjectAdded", invalidateConfig=true)
426426
member private this.OnProjectReloaded(projectId:ProjectId) = projectInfoManager.UpdateProjectInfoWithProjectId(projectId, "OnProjectReloaded", invalidateConfig=true)
427427
member private this.OnDocumentAdded(projectId:ProjectId, documentId:DocumentId) = projectInfoManager.UpdateDocumentInfoWithProjectId(projectId, documentId, "OnDocumentAdded", invalidateConfig=true)
428-
member private this.OnDocumentChanged(projectId:ProjectId, documentId:DocumentId) = projectInfoManager.UpdateDocumentInfoWithProjectId(projectId, documentId, "OnDocumentChanged", invalidateConfig=false)
429428
member private this.OnDocumentReloaded(projectId:ProjectId, documentId:DocumentId) = projectInfoManager.UpdateDocumentInfoWithProjectId(projectId, documentId, "OnDocumentReloaded", invalidateConfig=true)
430429

431430
override this.Initialize() =
@@ -437,7 +436,6 @@ type internal FSharpLanguageService(package : FSharpPackage) =
437436
| WorkspaceChangeKind.ProjectAdded -> this.OnProjectAdded(args.ProjectId)
438437
| WorkspaceChangeKind.ProjectReloaded -> this.OnProjectReloaded(args.ProjectId)
439438
| WorkspaceChangeKind.DocumentAdded -> this.OnDocumentAdded(args.ProjectId, args.DocumentId)
440-
| WorkspaceChangeKind.DocumentChanged -> this.OnDocumentChanged(args.ProjectId, args.DocumentId)
441439
| WorkspaceChangeKind.DocumentReloaded -> this.OnDocumentReloaded(args.ProjectId, args.DocumentId)
442440
| WorkspaceChangeKind.DocumentRemoved
443441
| WorkspaceChangeKind.ProjectRemoved
@@ -672,8 +670,7 @@ type internal FSharpLanguageService(package : FSharpPackage) =
672670
if not (h.IsCapabilityMatch("CPS")) then
673671
let fileContents = VsTextLines.GetFileContents(textLines, textViewAdapter)
674672
this.SetupStandAloneFile(filename, fileContents, this.Workspace, hier)
675-
| id ->
676-
projectInfoManager.UpdateProjectInfoWithProjectId(id.ProjectId, "SetupNewTextView", invalidateConfig=true)
673+
| _ -> ()
677674
| _ ->
678675
let fileContents = VsTextLines.GetFileContents(textLines, textViewAdapter)
679676
this.SetupStandAloneFile(filename, fileContents, this.Workspace, hier)

0 commit comments

Comments
 (0)