Skip to content
This repository was archived by the owner on Feb 25, 2021. It is now read-only.

Commit dd7fb4d

Browse files
authored
Merge pull request #1967 from dotnet/mkArtakMSFT-patch-1
Added details about how to run certain steps
2 parents 84d82f6 + 7869c51 commit dd7fb4d

File tree

1 file changed

+14
-3
lines changed

1 file changed

+14
-3
lines changed

src/Microsoft.AspNetCore.Blazor.Mono/HowToUpgradeMono.md

Lines changed: 14 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@
1111
1. Now on the sidebar, navigate to *Azure Artifacts*.
1212

1313
1. Download the .zip file. Note that the commit's SHA hash is in the filename - you'll need that later to track which Mono version we're using in Blazor.
14+
**NOTE**: The Jenkins UI may show some errors when opening a specific build. The `Shortcut` below is most probably still accessible, so move forward with it.
1415

1516
**Shortcut:** Browse directly to https://jenkins.mono-project.com/job/test-mono-mainline-wasm/255/label=ubuntu-1804-amd64/Azure/, replacing the number 255 with the desired build number.
1617

@@ -43,11 +44,21 @@ At this stage, make a Git commit with a message similar to `Upgrade Mono binarie
4344

4445
Push your change as a PR to the `blazor` repo. Once the CI system has built the resulting package, download it. It usually has a name like `Microsoft.AspNetCore.Blazor.Mono.3.2.0-ci.nupkg`.
4546

46-
Switch over to the `aspnetcore` repo and modify the `eng\Versions.props` file to use your new version (e.g., `3.2.0-ci`). To restore this correctly,
47-
47+
Switch over to the `aspnetcore` repo and modify the `eng\Versions.props` file to use your new version (e.g., `3.2.0-ci`). Locate the `MicrosoftAspNetCoreBlazorMonoPackageVersion` property and update the version to the desired version:
48+
```<MicrosoftAspNetCoreBlazorMonoPackageVersion>3.2.0-CI</MicrosoftAspNetCoreBlazorMonoPackageVersion>```
49+
50+
To restore this correctly:
51+
4852
* Make sure you don't already have a `-ci` version of that package in your NuGet package cache
4953
* Run a `dotnet restore` with `-s <directory_containing_the_download>`
5054

51-
Now try running the StandaloneApp and perf benchmarks to be sure the apps still work, and the size and perf numbers haven't regressed badly. Ideally, also run all the E2E tests.
55+
Now try running the StandaloneApp and perf benchmarks to be sure the apps still work, and the size and perf numbers haven't regressed badly.
56+
57+
After running the above checks, also run all the E2E tests:
58+
- switch to the `src\Components\test\E2ETest`
59+
- run `yarn install` to install the necessary packages (selenium, chrome debug adapter, ...)
60+
- if you don't have installed Java yet, do so
61+
- run `dotnet test` from the Command Line. Alternatively, you can open the solution file from this directory and run the tests from within VS.
62+
5263

5364
If everything looks good, you can proceed with merging your PR to the `blazor` repo.

0 commit comments

Comments
 (0)