Test methods can't return value

Author: akoeplinger

src/Servers/Kestrel/Core/test/Http1/Http1HttpProtocolFeatureCollectionTests.cs

@@ -47,55 +47,29 @@ public Http1HttpProtocolFeatureCollectionTests()
     }
 
     [Fact]
-    public int FeaturesStartAsSelf()
+    public void FeaturesStartAsSelf()
     {
-        var featureCount = 0;
-        foreach (var featureIter in _collection)
-        {
-            Type type = featureIter.Key;
-            if (type.IsAssignableFrom(typeof(HttpProtocol)))
-            {
-                var featureLookup = _collection[type];
-                Assert.Same(featureLookup, featureIter.Value);
-                Assert.Same(featureLookup, _collection);
-                featureCount++;
-            }
-        }
+        var featureCount = GetFeaturesCount();
 
         Assert.NotEqual(0, featureCount);
-
-        return featureCount;
     }
 
     [Fact]
-    public int FeaturesCanBeAssignedTo()
+    public void FeaturesCanBeAssignedTo()
     {
         var featureCount = SetFeaturesToNonDefault();
         Assert.NotEqual(0, featureCount);
 
-        featureCount = 0;
-        foreach (var feature in _collection)
-        {
-            Type type = feature.Key;
-            if (type.IsAssignableFrom(typeof(HttpProtocol)))
-            {
-                Assert.Same(_collection[type], feature.Value);
-                Assert.NotSame(_collection[type], _collection);
-                featureCount++;
-            }
-        }
-
+        featureCount = GetFeaturesCount();
         Assert.NotEqual(0, featureCount);
-
-        return featureCount;
     }
 
     [Fact]
     public void FeaturesResetToSelf()
     {
         var featuresAssigned = SetFeaturesToNonDefault();
         _http1Connection.ResetFeatureCollection();
-        var featuresReset = FeaturesStartAsSelf();
+        var featuresReset = GetFeaturesCount();
 
         Assert.Equal(featuresAssigned, featuresReset);
     }
@@ -108,7 +82,7 @@ public void FeaturesByGenericSameAsByType()
         CompareGenericGetterToIndexer();
 
         _http1Connection.ResetFeatureCollection();
-        var featuresReset = FeaturesStartAsSelf();
+        var featuresReset = GetFeaturesCount();
 
         Assert.Equal(featuresAssigned, featuresReset);
     }
@@ -235,6 +209,23 @@ private int EachHttpProtocolFeatureSetAndUnique()
         return featureCount;
     }
 
+    public int GetFeaturesCount()
+    {
+        var featureCount = 0;
+        foreach (var featureIter in _collection)
+        {
+            Type type = featureIter.Key;
+            if (type.IsAssignableFrom(typeof(HttpProtocol)))
+            {
+                var featureLookup = _collection[type];
+                Assert.Same(featureLookup, featureIter.Value);
+                Assert.Same(featureLookup, _collection);
+                featureCount++;
+            }
+        }
+        return featureCount;
+    }
+
     private int SetFeaturesToNonDefault()
     {
         int featureCount = 0;