Skip to content

Full passthrough of Doltgres overrides #10140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Hydrocharged merged 1 commit into from
Dec 12, 2025
Merged

Full passthrough of Doltgres overrides #10140

Hydrocharged merged 1 commit into from
Dec 12, 2025

Conversation

@Hydrocharged
Copy link
Contributor

@Hydrocharged Hydrocharged commented Dec 1, 2025

@Hydrocharged Hydrocharged requested a review from zachmu December 1, 2025 17:26
This was referenced Dec 1, 2025
Merged
Merged
zachmu
zachmu reviewed Dec 2, 2025
View reviewed changes
Copy link
Member

@zachmu zachmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fine, no objections to this approach.

@Hydrocharged Hydrocharged force-pushed the daylon/analyzer-passing branch 2 times, most recently from 17b2cca to 51a7a27 Compare December 12, 2025 10:19
@Hydrocharged Hydrocharged marked this pull request as ready for review December 12, 2025 10:19
@Hydrocharged Hydrocharged force-pushed the daylon/analyzer-passing branch from 51a7a27 to a009903 Compare December 12, 2025 10:21
@coffeegoddd
Copy link
Contributor

coffeegoddd commented Dec 12, 2025

@Hydrocharged DOLT

comparing_percentages
100.000000 to 100.000000
version result total
a009903 ok 5937471
version total_tests
a009903 5937471
correctness_percentage
100.0

@Hydrocharged Hydrocharged force-pushed the daylon/analyzer-passing branch from a009903 to 3f50c72 Compare December 12, 2025 13:25
@coffeegoddd
Copy link
Contributor

coffeegoddd commented Dec 12, 2025

@Hydrocharged DOLT

comparing_percentages
100.000000 to 100.000000
version result total
3f50c72 ok 5937471
version total_tests
3f50c72 5937471
correctness_percentage
100.0

@Hydrocharged Hydrocharged merged commit 22bca9e into main Dec 12, 2025
23 checks passed
@Hydrocharged Hydrocharged deleted the daylon/analyzer-passing branch December 12, 2025 14:09
This was referenced Dec 12, 2025
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zachmu zachmu zachmu left review comments

Assignees

No one assigned

Labels

correctness_approved

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Hydrocharged @coffeegoddd @zachmu