Skip to content

Commit d956afb

Browse files
committed
rm privs check in dolt_purge_dropped_databases as it is already handled
1 parent 16069d8 commit d956afb

File tree

1 file changed

+0
-20
lines changed

1 file changed

+0
-20
lines changed

go/libraries/doltcore/sqle/dprocedures/dolt_purge_dropped_databases.go

Lines changed: 0 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -27,11 +27,6 @@ func doltPurgeDroppedDatabases(ctx *sql.Context, args ...string) (sql.RowIter, e
2727
return nil, fmt.Errorf("dolt_purge_dropped_databases does not take any arguments")
2828
}
2929

30-
// Only allow admins to purge dropped databases
31-
if err := checkDoltPurgeDroppedDatabasesPrivs(ctx); err != nil {
32-
return nil, err
33-
}
34-
3530
doltSession := dsess.DSessFromSess(ctx.Session)
3631
err := doltSession.Provider().PurgeDroppedDatabases(ctx)
3732
if err != nil {
@@ -40,18 +35,3 @@ func doltPurgeDroppedDatabases(ctx *sql.Context, args ...string) (sql.RowIter, e
4035

4136
return rowToIter(int64(cmdSuccess)), nil
4237
}
43-
44-
// checkDoltPurgeDroppedDatabasesPrivs returns an error if the user requesting to purge dropped databases
45-
// does not have SUPER access. Since this is a permanent and destructive operation, we restrict it to admins,
46-
// even though the SUPER privilege has been deprecated, since there isn't another appropriate global privilege.
47-
func checkDoltPurgeDroppedDatabasesPrivs(ctx *sql.Context) error {
48-
privs, counter := ctx.GetPrivilegeSet()
49-
if counter == 0 {
50-
return fmt.Errorf("unable to check user privileges for dolt_purge_dropped_databases procedure")
51-
}
52-
if privs.Has(sql.PrivilegeType_Super) == false {
53-
return sql.ErrPrivilegeCheckFailed.New(ctx.Session.Client().User)
54-
}
55-
56-
return nil
57-
}

0 commit comments

Comments
 (0)