leave todo

James Cor · James Cor · commit d490f8501379 · 2025-12-09T22:24:48.000-08:00
diff --git a/go/libraries/doltcore/sqle/index/dolt_index.go b/go/libraries/doltcore/sqle/index/dolt_index.go
@@ -1408,6 +1408,7 @@ func getRangeCutValue(ctx context.Context, cut sql.MySQLRangeCut, typ sql.Type)
 		return nil, nil
 	}
 	ret, inRange, err := typ.Convert(ctx, sql.GetMySQLRangeCutKey(cut))
+	// TODO: seems like we should check for error before inRange, but certain tests fail
 	if inRange != sql.InRange {
 		return ret, nil
 	}

Original file line number	Diff line number	Diff line change
`@@ -1408,6 +1408,7 @@ func getRangeCutValue(ctx context.Context, cut sql.MySQLRangeCut, typ sql.Type)`
`1408`	`1408`	`return nil, nil`
`1409`	`1409`	`}`
`1410`	`1410`	`ret, inRange, err := typ.Convert(ctx, sql.GetMySQLRangeCutKey(cut))`
	`1411`	`+ // TODO: seems like we should check for error before inRange, but certain tests fail`
`1411`	`1412`	`if inRange != sql.InRange {`
`1412`	`1413`	`return ret, nil`
`1413`	`1414`	`}`