bug fix for kvexec

Author: zachmu

go/libraries/doltcore/sqle/kvexec/lookup_join.go

@@ -64,13 +64,13 @@ func (l *lookupJoinKvIter) Close(_ *sql.Context) error {
 var _ sql.RowIter = (*lookupJoinKvIter)(nil)
 
 func newLookupKvIter(
-	srcIter prolly.MapIter,
-	targetIter index.SecondaryLookupIterGen,
-	mapping *lookupMapping,
-	joiner *prollyToSqlJoiner,
-	srcFilter, dstFilter, joinFilter sql.Expression,
-	isLeftJoin bool,
-	excludeNulls bool,
+		srcIter prolly.MapIter,
+		targetIter index.SecondaryLookupIterGen,
+		mapping *lookupMapping,
+		joiner *prollyToSqlJoiner,
+		srcFilter, dstFilter, joinFilter sql.Expression,
+		isLeftJoin bool,
+		excludeNulls bool,
 ) (*lookupJoinKvIter, error) {
 	if lit, ok := joinFilter.(*expression.Literal); ok {
 		if lit.Value() == true {
@@ -199,12 +199,12 @@ type lookupMapping struct {
 }
 
 func newLookupKeyMapping(
-	ctx *sql.Context,
-	sourceSch schema.Schema,
-	tgtKeyDesc *val.TupleDesc,
-	keyExprs []sql.Expression,
-	typs []sql.ColumnExpressionType,
-	ns tree.NodeStore,
+		ctx *sql.Context,
+		sourceSch schema.Schema,
+		tgtKeyDesc *val.TupleDesc,
+		keyExprs []sql.Expression,
+		typs []sql.ColumnExpressionType,
+		ns tree.NodeStore,
 ) (*lookupMapping, error) {
 	keyless := schema.IsKeyless(sourceSch)
 	// |split| is an index into the schema separating the key and value fields
@@ -254,7 +254,7 @@ func newLookupKeyMapping(
 	for i, j := range litMappings {
 		colTyp := typs[j]
 		val, _, err := convertLiteralKeyValue(ctx, colTyp, keyExprs[j].(*expression.Literal))
-		if err != nil {
+		if err != nil && !sql.ErrTruncatedIncorrect.Is(err) {
 			return nil, err
 		}
 
@@ -305,7 +305,7 @@ func convertLiteralKeyValue(ctx *sql.Context, colTyp sql.ColumnExpressionType, v
 		}
 	}
 
-	return destType.Convert(ctx, val)
+	return destType.Convert(ctx, val.Value())
 }
 
 // valid returns whether the source and destination key types