Skip to content

Commit 111c34d

Browse files
authored
Merge pull request #9704 from dolthub/angela/groupby_bump
[no-release-notes] Make updates for new GroupBy validation in gms
2 parents 4b02944 + 1cbe8d9 commit 111c34d

File tree

5 files changed

+7
-7
lines changed

5 files changed

+7
-7
lines changed

go/go.mod

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ require (
6060
github.com/dolthub/aws-sdk-go-ini-parser v0.0.0-20250305001723-2821c37f6c12
6161
github.com/dolthub/eventsapi_schema v0.0.0-20250725194025-a087efa1ee55
6262
github.com/dolthub/flatbuffers/v23 v23.3.3-dh.2
63-
github.com/dolthub/go-mysql-server v0.20.1-0.20250820173946-c848ce92b781
63+
github.com/dolthub/go-mysql-server v0.20.1-0.20250820200253-9b7555658e70
6464
github.com/dolthub/gozstd v0.0.0-20240423170813-23a2903bca63
6565
github.com/edsrzf/mmap-go v1.2.0
6666
github.com/esote/minmaxheap v1.0.0

go/go.sum

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -213,8 +213,8 @@ github.com/dolthub/fslock v0.0.3 h1:iLMpUIvJKMKm92+N1fmHVdxJP5NdyDK5bK7z7Ba2s2U=
213213
github.com/dolthub/fslock v0.0.3/go.mod h1:QWql+P17oAAMLnL4HGB5tiovtDuAjdDTPbuqx7bYfa0=
214214
github.com/dolthub/go-icu-regex v0.0.0-20250820171420-f2b78f56ce9f h1:oSA8CptGeCEdTdD9LFtv8x4juDfdaLKsx1eocyaj1bE=
215215
github.com/dolthub/go-icu-regex v0.0.0-20250820171420-f2b78f56ce9f/go.mod h1:kpsRG+a196Y69zsAFL0RkQICII9a571lcaxhvQnmrdY=
216-
github.com/dolthub/go-mysql-server v0.20.1-0.20250820173946-c848ce92b781 h1:8Rl+8HEI64HRXtML5cDRFwvRmZbN5lJhQb5B6rhQcaU=
217-
github.com/dolthub/go-mysql-server v0.20.1-0.20250820173946-c848ce92b781/go.mod h1:2kd3E7pEmjYEDBgdd0CtZGyXR/lvKC5RlDeTNHAV6VI=
216+
github.com/dolthub/go-mysql-server v0.20.1-0.20250820200253-9b7555658e70 h1:HHYHW6X0z5P8n5KHZMzu0+MS3ePD7zbhj5ucZ+vhoGc=
217+
github.com/dolthub/go-mysql-server v0.20.1-0.20250820200253-9b7555658e70/go.mod h1:2kd3E7pEmjYEDBgdd0CtZGyXR/lvKC5RlDeTNHAV6VI=
218218
github.com/dolthub/gozstd v0.0.0-20240423170813-23a2903bca63 h1:OAsXLAPL4du6tfbBgK0xXHZkOlos63RdKYS3Sgw/dfI=
219219
github.com/dolthub/gozstd v0.0.0-20240423170813-23a2903bca63/go.mod h1:lV7lUeuDhH5thVGDCKXbatwKy2KW80L4rMT46n+Y2/Q=
220220
github.com/dolthub/ishell v0.0.0-20240701202509-2b217167d718 h1:lT7hE5k+0nkBdj/1UOSFwjWpNxf+LCApbRHgnCA17XE=

go/libraries/doltcore/sqle/kvexec/builder.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -93,8 +93,8 @@ func (b Builder) Build(ctx *sql.Context, n sql.Node, r sql.Row) (sql.RowIter, er
9393
}
9494
}
9595
case *plan.GroupBy:
96-
if len(n.GroupByExprs) == 0 && len(n.SelectedExprs) == 1 {
97-
if cnt, ok := n.SelectedExprs[0].(*aggregation.Count); ok {
96+
if len(n.GroupByExprs) == 0 && len(n.SelectDeps) == 1 {
97+
if cnt, ok := n.SelectDeps[0].(*aggregation.Count); ok {
9898
if _, _, srcIter, _, srcSchema, _, _, srcFilter, err := getSourceKv(ctx, n.Child, true); err == nil && srcSchema != nil && srcFilter == nil {
9999
iter, ok, err := newCountAggregationKvIter(srcIter, srcSchema, cnt.Child)
100100
if ok && err == nil {

integration-tests/bats/sql.bats

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2157,7 +2157,7 @@ SQL
21572157
[[ "$output" =~ " 5 " ]] || false
21582158
[[ "$output" =~ " 0 " ]] || false
21592159
[[ ! "$output" =~ " 4 " ]] || false
2160-
run dolt sql -r csv -q "select max(pk),c2 from one_pk group by c1"
2160+
run dolt sql -r csv -q "select max(pk),c2 from one_pk group by c2"
21612161
[ $status -eq 0 ]
21622162
[[ "$output" =~ "5,0" ]] || false
21632163
[[ "$output" =~ "1,10" ]] || false

integration-tests/mysql-client-tests/node/workbenchTests/table.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ export const tableTests = [
7575
table_name, index_name, comment, non_unique, GROUP_CONCAT(column_name ORDER BY seq_in_index) AS COLUMNS
7676
FROM information_schema.statistics
7777
WHERE table_schema=:tableSchema AND table_name=:tableName AND index_name!="PRIMARY"
78-
GROUP BY index_name;`,
78+
GROUP BY index_name, comment, non_unique;`,
7979
p: { tableSchema: `${dbName}/main`, tableName: "test" },
8080
res: [
8181
{

0 commit comments

Comments
 (0)