Skip to content

Commit 82b67c4

Browse files
committed
internal/jsonstream: TestDisplay use streamformatter
Similar to 69854c4, but for the internal/jsonstream package. Signed-off-by: Sebastiaan van Stijn <[email protected]>
1 parent e0af501 commit 82b67c4

File tree

1 file changed

+10
-16
lines changed

1 file changed

+10
-16
lines changed

internal/jsonstream/display_test.go

Lines changed: 10 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -2,14 +2,14 @@ package jsonstream
22

33
import (
44
"context"
5-
"encoding/json"
6-
"fmt"
75
"io"
86
"testing"
97
"time"
108

119
"github.com/docker/cli/cli/streams"
12-
"github.com/moby/moby/api/types/jsonstream"
10+
"github.com/docker/cli/internal/test"
11+
"github.com/moby/moby/api/pkg/progress"
12+
"github.com/moby/moby/api/pkg/streamformatter"
1313
"gotest.tools/v3/assert"
1414
)
1515

@@ -23,25 +23,19 @@ func TestDisplay(t *testing.T) {
2323
})
2424

2525
go func() {
26-
enc := json.NewEncoder(server)
26+
id := test.RandomID()[:12] // short-ID
27+
progressOutput := streamformatter.NewJSONProgressOutput(server, true)
2728
for i := 0; i < 100; i++ {
2829
select {
2930
case <-ctx.Done():
3031
assert.NilError(t, server.Close(), "failed to close jsonmessage server")
3132
return
3233
default:
33-
err := enc.Encode(JSONMessage{
34-
Status: "Downloading",
35-
ID: fmt.Sprintf("id-%d", i),
36-
TimeNano: time.Now().UnixNano(),
37-
Time: time.Now().Unix(),
38-
Progress: &JSONProgress{
39-
Progress: jsonstream.Progress{
40-
Current: int64(i),
41-
Total: 100,
42-
Start: 0,
43-
},
44-
},
34+
err := progressOutput.WriteProgress(progress.Progress{
35+
ID: id,
36+
Message: "Downloading",
37+
Current: int64(i),
38+
Total: 100,
4539
})
4640
if err != nil {
4741
break

0 commit comments

Comments
 (0)