Merge pull request #27 from dnetix/fix-nvp-value-type

Fix NVP value type

Author: dnetix

src/Entities/NameValuePair.php

@@ -7,7 +7,7 @@
 class NameValuePair extends Entity
 {
     protected string $keyword;
-    protected string $value = '';
+    protected $value;
     protected string $displayOn = 'none';
 
     public function __construct($data = [])
@@ -20,7 +20,10 @@ public function keyword(): string
         return $this->keyword;
     }
 
-    public function value(): string
+    /**
+     * @return string|array
+     */
+    public function value()
     {
         return $this->value;
     }

tests/Functionality/ServiceQueryTest.php

@@ -26,6 +26,29 @@ public function testItHandlesANonExistentSession()
         $this->assertNull($response->request());
     }
 
+    public function testItHandlesCustomNameValuePairs()
+    {
+        $response = $this->getService()->query(10010);
+
+        $this->assertSame([
+            'merchantCode' => '1065152',
+            'terminalNumber' => '00990099',
+            'credit' => [
+                'code' => 1,
+                'type' => '03',
+                'groupCode' => 'X',
+                'installments' => 9,
+            ],
+            'totalAmount' => 3809000,
+            'interestAmount' => 0,
+            'installmentAmount' => 423205.13,
+            'iceAmount' => 0,
+            'bin' => '365454',
+            'expiration' => '1122',
+            'lastDigits' => '0008',
+        ], $response->lastTransaction()->additionalData());
+    }
+
     public function testItHandlesABankAccountSubscription()
     {
         $response = $this->getService()->query(10009);

tests/Mocks/RestCarrierMock.php

@@ -140,6 +140,9 @@ public function query($requestId): FulfilledPromise
             case 10009:
                 $response = '{"requestId": 10009,"status": {"status": "APPROVED","reason": "00","message": "La petición ha sido aprobada exitosamente","date": "2021-09-14T19:16:59-05:00"},"request": {"locale": "es_CO","buyer": {"document": "1040035000","documentType": "CC","name": "Nakia","surname": "Walker","email": "[email protected]","mobile": 3006108300},"payer": {"document": "1040035000","documentType": "CC","name": "Nakia","surname": "Walker","email": "[email protected]","mobile": 3006108300},"subscription": {"reference": "800166551","description": "Pago en micrositio"},"returnUrl": "https://dnetix.co/ping/test","ipAddress": "186.84.220.137","userAgent": "Mozilla/5.0 (iPhone; CPU iPhone OS 14_6 like Mac OS X) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/14.1.1 Mobile/15E148 Safari/604.1","expiration": "2021-09-19T17:05:23-05:00"},"payment": null,"subscription": {"type": "account","status": {"status": "OK","reason": "00","message": "Account stored successfully","date": "2021-09-15T00:16:45.345048Z"},"instrument": [{"keyword": "bankCode","value": "007","displayOn": "none"},{"keyword": "bankName","value": "Bancolombia","displayOn": "none"},{"keyword": "accountType","value": "A","displayOn": "none"},{"keyword": "accountNumber","value": "00849514000","displayOn": "none"}]}}';
                 break;
+            case 10010:
+                $response = '{"requestId": 328759,"status": {"status": "APPROVED","reason": "00","message": "La petici\u00f3n ha sido aprobada exitosamente","date": "2021-09-23T19:00:08-05:00"},"request": {"locale": "es_CO","buyer": {"document": "1040035000","documentType": "CC","name": "Nakia","surname": "Walker","email": "[email protected]","mobile": 3006108300},"payer": {"document": "1036949824","documentType": "CI","name": "Diego","surname": "osorio","email": "[email protected]","mobile": "3102903560"},"payment": {"reference": "800166551","description": "Pago en micrositio","amount": {"currency": "COP","total": 3809000},"allowPartial": true,"subscribe": false},"fields": [{"keyword": "_processUrl_","value": "https:\/\/test.placetopay.ec\/redirection\/session\/328759\/ccad4021c274a7dc3ef71f526f2b1cb5","displayOn": "none"}],"returnUrl": "https:\/\/dnetix.co\/ping\/test","ipAddress": "186.84.220.137","userAgent": "Mozilla\/5.0 (iPhone; CPU iPhone OS 14_6 like Mac OS X) AppleWebKit\/605.1.15 (KHTML, like Gecko) Version\/14.1.1 Mobile\/15E148 Safari\/604.1","expiration": "2021-10-19T17:05:23-05:00"},"payment": [{"status": {"status": "APPROVED","reason": "00","message": "Aprobada","date": "2021-09-23T18:59:45-05:00"},"internalReference": "230192","paymentMethod": "diners","paymentMethodName": "Diners","issuerName": "Diners","amount": {"from": {"currency": "COP","total": 3809000},"to": {"currency": "USD","total": 990.58},"factor": 0.0002600630086636913},"authorization": "999999","reference": "800166551","receipt": "230192","franchise": "ID_DN","refunded": false,"processorFields": [{"keyword": "merchantCode","value": "1065152","displayOn": "none"},{"keyword": "terminalNumber","value": "00990099","displayOn": "none"},{"keyword": "credit","value": {"code": 1,"type": "03","groupCode": "X","installments": 9},"displayOn": "none"},{"keyword": "totalAmount","value": 3809000.0,"displayOn": "none"},{"keyword": "interestAmount","value": 0,"displayOn": "none"},{"keyword": "installmentAmount","value": 423205.13,"displayOn": "none"},{"keyword": "iceAmount","value": 0,"displayOn": "none"},{"keyword": "bin","value": "365454","displayOn": "none"},{"keyword": "expiration","value": "1122","displayOn": "none"},{"keyword": "lastDigits","value": "0008","displayOn": "none"}]}],"subscription": null}';
+                break;
             default:
                 $response = '{"status":{"status":"FAILED","reason":0,"message":"No existe la sesi\u00f3n que busca","date":"' . date('c') . '"}}';
         }