Skip to content

Commit d50cfd7

Browse files
committed
Switch from log to tracing
Given that this library makes use of async code, it's useful to use spans.
1 parent b62d18b commit d50cfd7

File tree

6 files changed

+11
-11
lines changed

6 files changed

+11
-11
lines changed

Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@ base64 = "0.13"
2020
dirs-next = "2.0"
2121
hyper = { version = "0.14.2", features = ["client", "runtime", "http2"] }
2222
hyper-rustls = { version = "0.23.0", default-features = false, features = ["native-tokio", "http1", "http2"] }
23-
log = "0.4"
2423
ring = "0.16.20"
2524
rustls = "0.20.2"
2625
rustls-pemfile = "0.2.1"
@@ -29,6 +28,7 @@ serde_json = "1.0"
2928
thiserror = "1.0"
3029
time = { version = "0.3.5", features = ["serde"] }
3130
tokio = { version = "1.1", features = ["fs", "sync"] }
31+
tracing = "0.1.29"
3232
url = "2"
3333
which = "4.2"
3434

src/authentication_manager.rs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -43,31 +43,31 @@ impl AuthenticationManager {
4343
/// 4. Look for credentials in `.config/gcloud/application_default_credentials.json`;
4444
/// if found, use these credentials to request refresh tokens.
4545
pub async fn new() -> Result<Self, Error> {
46-
log::debug!("Initializing gcp_auth");
46+
tracing::debug!("Initializing gcp_auth");
4747
if let Some(service_account) = CustomServiceAccount::from_env()? {
4848
return Ok(Self::from_custom_service_account(service_account));
4949
}
5050

5151
let client = types::client();
5252
let gcloud_error = match GCloudAuthorizedUser::new() {
5353
Ok(service_account) => {
54-
log::debug!("Using GCloudAuthorizedUser");
54+
tracing::debug!("Using GCloudAuthorizedUser");
5555
return Ok(Self::build(client, service_account));
5656
}
5757
Err(e) => e,
5858
};
5959

6060
let default_service_error = match DefaultServiceAccount::new(&client).await {
6161
Ok(service_account) => {
62-
log::debug!("Using DefaultServiceAccount");
62+
tracing::debug!("Using DefaultServiceAccount");
6363
return Ok(Self::build(client, service_account));
6464
}
6565
Err(e) => e,
6666
};
6767

6868
let default_user_error = match DefaultAuthorizedUser::new(&client).await {
6969
Ok(service_account) => {
70-
log::debug!("Using DefaultAuthorizedUser");
70+
tracing::debug!("Using DefaultAuthorizedUser");
7171
return Ok(Self::build(client, service_account));
7272
}
7373
Err(e) => e,

src/custom_service_account.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ impl CustomServiceAccount {
2323
pub fn from_env() -> Result<Option<Self>, Error> {
2424
std::env::var_os("GOOGLE_APPLICATION_CREDENTIALS")
2525
.map(|path| {
26-
log::debug!("Reading credentials file from GOOGLE_APPLICATION_CREDENTIALS env var");
26+
tracing::debug!("Reading credentials file from GOOGLE_APPLICATION_CREDENTIALS env var");
2727
Self::from_file(&PathBuf::from(path))
2828
})
2929
.transpose()
@@ -100,7 +100,7 @@ impl ServiceAccount for CustomServiceAccount {
100100
.body(hyper::Body::from(rqbody))
101101
.unwrap();
102102

103-
log::debug!("requesting token from service account: {:?}", request);
103+
tracing::debug!("requesting token from service account: {:?}", request);
104104
let token = client
105105
.request(request)
106106
.await

src/default_authorized_user.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ impl DefaultAuthorizedUser {
3636
}
3737

3838
async fn get_token(client: &HyperClient) -> Result<Token, Error> {
39-
log::debug!("Loading user credentials file");
39+
tracing::debug!("Loading user credentials file");
4040
let mut home = dirs_next::home_dir().ok_or(Error::NoHomeDir)?;
4141
home.push(Self::USER_CREDENTIALS_PATH);
4242

src/default_service_account.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ impl DefaultServiceAccount {
3535
}
3636

3737
async fn get_token(client: &HyperClient) -> Result<Token, Error> {
38-
log::debug!("Getting token from GCP instance metadata server");
38+
tracing::debug!("Getting token from GCP instance metadata server");
3939
let req = Self::build_token_request(Self::DEFAULT_TOKEN_GCP_URI);
4040
let token = client
4141
.request(req)
@@ -50,7 +50,7 @@ impl DefaultServiceAccount {
5050
#[async_trait]
5151
impl ServiceAccount for DefaultServiceAccount {
5252
async fn project_id(&self, client: &HyperClient) -> Result<String, Error> {
53-
log::debug!("Getting project ID from GCP instance metadata server");
53+
tracing::debug!("Getting project ID from GCP instance metadata server");
5454
let req = Self::build_token_request(Self::DEFAULT_PROJECT_ID_GCP_URI);
5555
let rsp = client.request(req).await.map_err(Error::ConnectionError)?;
5656

src/util.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ impl HyperExt for hyper::Response<hyper::body::Body> {
2727
parts.status,
2828
String::from_utf8_lossy(body.as_ref())
2929
);
30-
log::error!("{}", error);
30+
tracing::error!("{}", error);
3131
return Err(Error::ServerUnavailable(error));
3232
}
3333

0 commit comments

Comments
 (0)