fix: Better env specific tasks

Author: dignifiedquire

README.md

@@ -123,16 +123,23 @@ $ gulp build
 
 ```bash
 # Major release
-$ gulp release major
-$ aegir-release major
+$ gulp release --type major
+$ aegir-release --type major
 # Minor relase
-$ gulp release minor
-$ aegir-release minor
+$ gulp release --type minor
+$ aegir-release --type minor
 # Patch release
 $ gulp release
 $ aegir-release
 ```
 
+You can also specify a `--env` for a release, which can be either
+`'node'`, `'browser'` or `'no-build'`.
+
+```bash
+$ aegir-release --env node
+$ gulp release --env node
+```
 
 ## Other Notes
 

bin/release

@@ -3,17 +3,8 @@
 'use strict'
 
 const gulp = require('gulp')
-const args = require('args-parser')(process.argv)
 
 require('../src/gulp-log')(gulp)
 require('../gulp')(gulp)
 
-if (args.browser) {
-  gulp.start('release:browser')
-} else if (args.node) {
-  gulp.start('release:node')
-} else if (args['no-build']) {
-  gulp.start('release-no-build')
-} else {
-  gulp.start('release')
-}
+gulp.start('release')

tasks/release.js

@@ -1,12 +1,21 @@
 'use strict'
 
+const $ = require('gulp-load-plugins')()
 const runSequence = require('run-sequence')
+const _ = require('lodash')
+
+function getEnv () {
+  if (_.includes($.util.env._, 'browser')) return 'browser'
+  if (_.includes($.util.env._, 'node')) return 'node'
+  if (_.includes($.util.env._, 'no-build')) return 'no-build'
+  if ($.util.env.env) return $.util.env.env
+
+  return 'default'
+}
 
 module.exports = (gulp, done) => {
   runSequence.use(gulp)(
-    'release:pre-build',
-    'build',
-    'release:post-build',
+    `release:${getEnv()}`,
     done
   )
 }

tasks/release/browser.js

@@ -3,8 +3,16 @@
 const runSequence = require('run-sequence')
 
 module.exports = (gulp, done) => {
+  gulp.task('release:pre-build:browser', (done1) => {
+    runSequence.use(gulp)(
+      'lint',
+      'test:browser',
+      done1
+    )
+  })
+
   runSequence.use(gulp)(
-    'release:pre-build',
+    'release:pre-build:browser',
     'build:browser',
     'release:post-build',
     done

tasks/release/bump.js

@@ -8,6 +8,7 @@ const _ = require('lodash')
 function getType () {
   if (_.includes($.util.env._, 'major')) return 'major'
   if (_.includes($.util.env._, 'minor')) return 'minor'
+  if ($.util.env.type) return $.util.env.type
 
   return 'patch'
 }

tasks/release-no-build.js renamed to tasks/release/default.js

@@ -5,6 +5,7 @@ const runSequence = require('run-sequence')
 module.exports = (gulp, done) => {
   runSequence.use(gulp)(
     'release:pre-build',
+    'build',
     'release:post-build',
     done
   )

tasks/release/no-build.js

@@ -0,0 +1,18 @@
+'use strict'
+
+const runSequence = require('run-sequence')
+
+module.exports = (gulp, done) => {
+  gulp.task('release:pre-build:no-build', (done1) => {
+    runSequence.use(gulp)(
+      'lint',
+      done1
+    )
+  })
+
+  runSequence.use(gulp)(
+    'release:pre-build:no-build',
+    'release:post-build',
+    done
+  )
+}

tasks/release/node.js

@@ -3,8 +3,16 @@
 const runSequence = require('run-sequence')
 
 module.exports = (gulp, done) => {
+  gulp.task('release:pre-build:node', (done1) => {
+    runSequence.use(gulp)(
+      'lint',
+      'test:node',
+      done1
+    )
+  })
+
   runSequence.use(gulp)(
-    'release:pre-build',
+    'release:pre-build:node',
     'build:node',
     'release:post-build',
     done

tasks/release/post-build.js

@@ -4,8 +4,8 @@ const runSequence = require('run-sequence')
 
 module.exports = (gulp, done) => {
   runSequence.use(gulp)(
-    'release:bump',
     'release:contributors',
+    'release:bump',
     'release:push',
     'release:publish',
     done