Skip to content

Commit d3196b4

Browse files
committed
Set type="submit" when rendering a submitButton. Fixes #1439
1 parent f97b9c9 commit d3196b4

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

IHP/View/CSSFramework.hs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -234,7 +234,7 @@ instance Default CSSFramework where
234234

235235
styledSubmitButton cssFramework SubmitButton { label, buttonClass } =
236236
let className :: Text = get #styledSubmitButtonClass cssFramework
237-
in [hsx|<button class={classes [(className, True), (buttonClass, not (null buttonClass))]}>{label}</button>|]
237+
in [hsx|<button class={classes [(className, True), (buttonClass, not (null buttonClass))]} type="submit">{label}</button>|]
238238

239239
styledInputClass _ _ = ""
240240
styledInputInvalidClass _ _ = "invalid"

Test/View/CSSFrameworkSpec.hs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,10 +42,10 @@ tests = do
4242
describe "submit button" do
4343
let submitButton = SubmitButton { label = "Save Project" , buttonClass = "my-custom-button" , cssFramework }
4444
it "should render" do
45-
styledSubmitButton cssFramework cssFramework submitButton `shouldRenderTo` "<button class=\"btn btn-primary my-custom-button\">Save Project</button>"
45+
styledSubmitButton cssFramework cssFramework submitButton `shouldRenderTo` "<button class=\"btn btn-primary my-custom-button\" type=\"submit\">Save Project</button>"
4646

4747
it "should render with empty class" do
48-
styledSubmitButton cssFramework cssFramework (submitButton { buttonClass = "" }) `shouldRenderTo` "<button class=\"btn btn-primary\">Save Project</button>"
48+
styledSubmitButton cssFramework cssFramework (submitButton { buttonClass = "" }) `shouldRenderTo` "<button class=\"btn btn-primary\" type=\"submit\">Save Project</button>"
4949

5050

5151
describe "text field" do

0 commit comments

Comments
 (0)