Added autoPolicy behaviour from IHP backend

Author: mpscholten

IHP/IDE/SchemaDesigner/Controller/Columns.hs

@@ -49,6 +49,7 @@ instance Controller ColumnsController where
                         , referenceTable = paramOrNothing "referenceTable"
                         , primaryKey = param "primaryKey"
                         , withIndex = paramOrDefault False "withIndex"
+                        , autoPolicy = paramOrDefault False "autoPolicy"
                         }
                 updateSchema $ SchemaOperations.addColumn options
 

IHP/IDE/SchemaDesigner/SchemaOperations.hs

@@ -43,6 +43,7 @@ data AddColumnOptions = AddColumnOptions
     , referenceTable :: !(Maybe Text)
     , primaryKey :: !Bool
     , withIndex :: !Bool
+    , autoPolicy :: !Bool
     }
 addColumn :: AddColumnOptions -> Schema -> Schema
 addColumn options@(AddColumnOptions { .. }) =
@@ -62,12 +63,34 @@ addColumn options@(AddColumnOptions { .. }) =
 
         foreignKeyConstraint = newForeignKeyConstraint tableName columnName (fromJust referenceTable)
         index = newColumnIndex tableName columnName
+
+        handleAutoPolicy statements =
+            if autoPolicy
+                then
+                    let
+                        isTable (StatementCreateTable CreateTable { name }) = name == tableName
+                        isTable otherwise = False
+                        (Just table) = find isTable statements
+                        suggestedPolicy = suggestPolicy statements table
+                    in if (get #name suggestedPolicy /= "" && not (doesHaveExistingPolicies statements tableName))
+                            then
+                                statements
+                                |> enableRowLevelSecurity tableName
+                                |> addPolicy AddPolicyOptions
+                                        { tableName = tableName
+                                        , name = get #name suggestedPolicy
+                                        , using = get #using suggestedPolicy
+                                        , check = get #check suggestedPolicy
+                                        }
+                            else statements
+                else statements
     in
         if isReference then
             \statements -> statements
             |> addTableOp
             |> appendStatement index
             |> appendStatement foreignKeyConstraint
+            |> handleAutoPolicy
         else
             addTableOp
             . (if withIndex
@@ -465,3 +488,10 @@ isIndexStatementReferencingTableColumn statement tableName columnName = isRefere
             LessThanOrEqualToExpression a b -> expressionReferencesColumn a || expressionReferencesColumn b
             GreaterThanExpression a b -> expressionReferencesColumn a || expressionReferencesColumn b
             GreaterThanOrEqualToExpression a b -> expressionReferencesColumn a || expressionReferencesColumn b
+
+doesHaveExistingPolicies :: [Statement] -> Text -> Bool
+doesHaveExistingPolicies statements tableName = statements
+                |> find \case
+                    CreatePolicy { tableName = tableName' } -> tableName' == tableName
+                    otherwise                               -> False
+                |> isJust

Test/IDE/SchemaDesigner/SchemaOperationsSpec.hs

@@ -210,6 +210,7 @@ tests = do
                         , referenceTable = Nothing
                         , primaryKey = False
                         , withIndex = True
+                        , autoPolicy = False
                         }
 
                 (SchemaOperations.addColumn options inputSchema) `shouldBe` expectedSchema
@@ -266,6 +267,68 @@ tests = do
                         , referenceTable = Nothing
                         , primaryKey = False
                         , withIndex = False
+                        , autoPolicy = False
+                        }
+
+                (SchemaOperations.addColumn options inputSchema) `shouldBe` expectedSchema
+            
+            it "should add a policy if autoPolicy = true" do
+                let inputSchema = [tableA]
+
+                let tableAWithCreatedAt = StatementCreateTable CreateTable
+                            { name = "a"
+                            , columns = [
+                                    Column
+                                        { name = "user_id"
+                                        , columnType = PUUID
+                                        , defaultValue = Nothing
+                                        , notNull = True
+                                        , isUnique = False
+                                        , generator = Nothing
+                                        }
+                            ]
+                            , primaryKeyConstraint = PrimaryKeyConstraint []
+                            , constraints = []
+                            }
+
+                let index = CreateIndex
+                        { indexName = "a_user_id_index"
+                        , unique = False
+                        , tableName = "a"
+                        , columns = [IndexColumn { column = VarExpression "user_id", columnOrder = [] }]
+                        , whereClause = Nothing
+                        , indexType = Nothing
+                        }
+                let constraint = AddConstraint
+                        { tableName = "a"
+                        , constraint = ForeignKeyConstraint { name = Just "a_ref_user_id", columnName = "user_id", referenceTable = "users", referenceColumn = Just "id", onDelete = Just NoAction }
+                        , deferrable = Nothing
+                        , deferrableType = Nothing
+                        }
+                let enableRLS = EnableRowLevelSecurity { tableName = "a" }
+                let policy = CreatePolicy
+                        { name = "Users can manage their a"
+                        , tableName = "a"
+                        , action = Nothing
+                        , using = Just (EqExpression (VarExpression "user_id") (CallExpression "ihp_user_id" []))
+                        , check = Just (EqExpression (VarExpression "user_id") (CallExpression "ihp_user_id" []))
+                        }
+
+                let expectedSchema = [tableAWithCreatedAt, index, constraint, enableRLS, policy]
+                
+                let options = SchemaOperations.AddColumnOptions
+                        { tableName = "a"
+                        , columnName = "user_id"
+                        , columnType = PUUID
+                        , defaultValue = Nothing
+                        , isArray = False
+                        , allowNull = False
+                        , isUnique = False
+                        , isReference = True
+                        , referenceTable = Just "users"
+                        , primaryKey = False
+                        , withIndex = False
+                        , autoPolicy = True
                         }
 
                 (SchemaOperations.addColumn options inputSchema) `shouldBe` expectedSchema
@@ -301,7 +364,6 @@ tests = do
                 (SchemaOperations.deleteColumn options inputSchema) `shouldBe` expectedSchema
 
             it "should delete a updated_at trigger" do
-
                 let tableAWithCreatedAt = StatementCreateTable CreateTable
                             { name = "a"
                             , columns = [