fix: panic fix on concurrent deletion request (#6644)

* fix on concurrent request

* add logging for missing pipeline objects in workflow and deployment services

Author: Shivam-nagar23

pkg/appWorkflow/AppWorkflowService.go

@@ -616,6 +616,10 @@ func (impl AppWorkflowServiceImpl) FindAppWorkflowsByEnvironmentId(request resou
 	}
 	appResults, envResults := request.CheckAuthBatch(token, appObjectArr, envObjectArr)
 	for _, pipeline := range pipelines {
+		if _, ok := objects[pipeline.Id]; !ok {
+			impl.Logger.Warnw("pipeline not found in objects map", "pipelineId", pipeline.Id)
+			continue
+		}
 		appObject := objects[pipeline.Id][0]
 		envObject := objects[pipeline.Id][1]
 		if !(appResults[appObject] && envResults[envObject]) {

pkg/bulkAction/service/BulkUpdateService.go

@@ -1336,6 +1336,13 @@ func (impl BulkUpdateServiceImpl) BulkDeploy(request *bean4.BulkApplicationForEn
 			pResponse[pipelineKey] = false
 			response[appKey] = pResponse
 		}
+		if _, ok := objects[pipeline.Id]; !ok {
+			//if user unauthorized, skip items
+			pipelineResponse := response[appKey]
+			pipelineResponse[pipelineKey] = false
+			response[appKey] = pipelineResponse
+			continue
+		}
 		appObject := objects[pipeline.Id][0]
 		envObject := objects[pipeline.Id][1]
 		if !(appResults[appObject] && envResults[envObject]) {

pkg/pipeline/CdHandler.go

@@ -735,6 +735,10 @@ func (impl *CdHandlerImpl) FetchAppWorkflowStatusForTriggerViewForEnvironment(re
 	// filter out pipelines for unauthorized apps but not envs
 	appResults, _ := request.CheckAuthBatch(token, appObjectArr, envObjectArr)
 	for _, pipeline := range pipelines {
+		if _, ok := objects[pipeline.Id]; !ok {
+			impl.Logger.Warnw("skipping pipeline as no object found for it", "pipelineId", pipeline.Id)
+			continue
+		}
 		appObject := objects[pipeline.Id][0]
 		if !(appResults[appObject]) {
 			// if user unauthorized, skip items
@@ -877,6 +881,10 @@ func (impl *CdHandlerImpl) FetchAppDeploymentStatusForEnvironments(request resou
 	}
 	appResults, envResults := request.CheckAuthBatch(token, appObjectArr, envObjectArr)
 	for _, pipeline := range cdPipelines {
+		if _, ok := objects[pipeline.Id]; !ok {
+			impl.Logger.Warnw("skipping pipeline as no object found for it", "pipelineId", pipeline.Id)
+			continue
+		}
 		appObject := objects[pipeline.Id][0]
 		envObject := objects[pipeline.Id][1]
 		if !(appResults[appObject] && envResults[envObject]) {

pkg/pipeline/DeploymentPipelineConfigService.go

@@ -1897,6 +1897,10 @@ func (impl *CdPipelineConfigServiceImpl) GetCdPipelinesByEnvironmentMin(request
 	//authorization block ends here
 	span.End()
 	for _, dbPipeline := range pipelines {
+		if _, ok := objects[dbPipeline.Id]; !ok {
+			impl.logger.Warnw("no objects found for pipeline", "pipelineId", dbPipeline.Id)
+			continue
+		}
 		appObject := objects[dbPipeline.Id][0]
 		envObject := objects[dbPipeline.Id][1]
 		if !(appResults[appObject] && envResults[envObject]) {
@@ -2133,6 +2137,10 @@ func (impl *CdPipelineConfigServiceImpl) GetEnvironmentListForAutocompleteFilter
 
 	pipelinesMap := make(map[int][]*pipelineConfig.Pipeline)
 	for _, pipeline := range cdPipelines {
+		if _, ok := objects[pipeline.Id]; !ok {
+			impl.logger.Warnw("skipping pipeline as no object found for it", "pipelineId", pipeline.Id)
+			continue
+		}
 		appObject := objects[pipeline.Id][0]
 		envObject := objects[pipeline.Id][1]
 		if !(appResults[appObject] && envResults[envObject]) {

pkg/pipeline/DevtronAppConfigService.go

@@ -222,6 +222,10 @@ func (impl *DevtronAppConfigServiceImpl) GetAppListForEnvironment(request resour
 	}
 	appResults, envResults := request.CheckAuthBatch(token, appObjectArr, envObjectArr)
 	for _, pipeline := range cdPipelines {
+		if _, ok := objects[pipeline.Id]; !ok {
+			impl.logger.Warnw("skipping pipeline as no app and env object found", "pipelineId", pipeline.Id)
+			continue
+		}
 		appObject := objects[pipeline.Id][0]
 		envObject := objects[pipeline.Id][1]
 		if !(appResults[appObject] && envResults[envObject]) {