Add missing 404 whitelist.

Author: dereuromark

src/Error/ErrorHandler.php

@@ -5,6 +5,7 @@
 use Cake\Error\ErrorHandler as CoreErrorHandler;
 use Cake\Log\Log;
 use Exception;
+use Tools\Error\Middleware\ErrorHandlerMiddleware;
 
 /**
  * Custom ErrorHandler to not mix the 404 exceptions with the rest of "real" errors in the error.log file.
@@ -37,21 +38,7 @@ class ErrorHandler extends CoreErrorHandler {
 	 * @return bool
 	 */
 	protected function _logException(Exception $exception) {
-		$blacklist = [
-			'Cake\Routing\Exception\MissingControllerException',
-			'Cake\Routing\Exception\MissingActionException',
-			'Cake\Routing\Exception\PrivateActionException',
-			'Cake\Routing\Exception\NotFoundException',
-			'Cake\Datasource\Exception\RecordNotFoundException',
-			'Cake\Network\Exception\MethodNotAllowedException',
-			'Cake\Network\Exception\BadRequestException',
-			'Cake\Network\Exception\ForbiddenException',
-			'Cake\Network\Exception\GoneException',
-			'Cake\Network\Exception\ConflictException',
-			'Cake\Network\Exception\InvalidCsrfToken',
-			'Cake\Network\Exception\UnauthorizedException',
-			'Cake\Network\Exception\NotAcceptableException',
-		];
+		$blacklist = ErrorHandlerMiddleware::$blacklist;
 		if (isset($this->_options['log404'])) {
 			$blacklist = $this->_options['log404'];
 		}

src/Error/Middleware/ErrorHandlerMiddleware.php

@@ -3,8 +3,13 @@
 namespace Tools\Error\Middleware;
 
 use Cake\Core\Configure;
+use Cake\Datasource\Exception\RecordNotFoundException;
 use Cake\Error\Middleware\ErrorHandlerMiddleware as CoreErrorHandlerMiddleware;
 use Cake\Log\Log;
+use Cake\Network\Exception\BadRequestException;
+use Cake\Network\Exception\MethodNotAllowedException;
+use Cake\Network\Exception\NotAcceptableException;
+use Cake\Network\Exception\NotFoundException;
 
 /**
  * Error handling middleware.
@@ -30,6 +35,25 @@
  */
 class ErrorHandlerMiddleware extends CoreErrorHandlerMiddleware {
 
+	/**
+	 * @var array
+	 */
+	public static $blacklist = [
+		NotFoundException::class,
+		MethodNotAllowedException::class,
+		NotAcceptableException::class,
+		RecordNotFoundException::class,
+		BadRequestException::class,
+		'Cake\Network\Exception\GoneException',
+		'Cake\Network\Exception\ConflictException',
+		'Cake\Network\Exception\InvalidCsrfToken',
+		'Cake\Network\Exception\UnauthorizedException',
+		'Cake\Routing\Exception\MissingControllerException',
+		'Cake\Routing\Exception\MissingActionException',
+		'Cake\Routing\Exception\PrivateActionException',
+		'Cake\Routing\Exception\NotFoundException',
+	];
+
 	/**
 	 * @param string|callable|null $renderer The renderer or class name
 	 *   to use or a callable factory.
@@ -53,21 +77,7 @@ public function __construct($renderer = null, array $config = []) {
 	 * @return void
 	 */
 	protected function logException($request, $exception) {
-		$blacklist = [
-			'Cake\Routing\Exception\MissingControllerException',
-			'Cake\Routing\Exception\MissingActionException',
-			'Cake\Routing\Exception\PrivateActionException',
-			'Cake\Routing\Exception\NotFoundException',
-			'Cake\Datasource\Exception\RecordNotFoundException',
-			'Cake\Network\Exception\MethodNotAllowedException',
-			'Cake\Network\Exception\BadRequestException',
-			'Cake\Network\Exception\ForbiddenException',
-			'Cake\Network\Exception\GoneException',
-			'Cake\Network\Exception\ConflictException',
-			'Cake\Network\Exception\InvalidCsrfToken',
-			'Cake\Network\Exception\UnauthorizedException',
-			'Cake\Network\Exception\NotAcceptableException',
-		];
+		$blacklist = static::$blacklist;
 		if (isset($this->_config['log404'])) {
 			$blacklist = $this->_config['log404'];
 		}