Require current password as soon as new password is entered.

Author: dereuromark

src/Model/Behavior/PasswordableBehavior.php

@@ -179,7 +179,13 @@ public function initialize(array $config) {
 
 		if ($this->_config['current'] && !count($validator->field($formFieldCurrent))) {
 			$validator->add($formFieldCurrent, $rules['formFieldCurrent']);
-			$validator->allowEmpty($formFieldCurrent, !$this->_config['require']);
+			$require = $this->_config['require'];
+			$validator->allowEmpty($formFieldCurrent, function ($context) use ($require, $formField) {
+				if (!$require && !empty($context['data'][$formField])) {
+					return false;
+				}
+				return !$require;
+			});
 
 			if (!$this->_config['allowSame']) {
 				$validator->add($formField, 'validateNotSame', [

tests/TestCase/Model/Behavior/PasswordableBehaviorTest.php

@@ -67,7 +67,7 @@ public function testValidate() {
 		$this->Users->patchEntity($user, $data);
 		$is = $this->Users->save($user);
 		$this->assertFalse($is);
-		$this->assertEquals(['pwd_repeat'], array_keys($user->errors()));
+		$this->assertEquals(['pwd_repeat'], array_keys((array)$user->errors()));
 
 		$user = $this->Users->newEntity();
 		$data = [
@@ -121,7 +121,7 @@ public function testValidateRequired() {
 		$this->Users->patchEntity($user, $data);
 		$is = $this->Users->save($user);
 		$this->assertFalse($is);
-		$this->assertEquals(['pwd', 'pwd_repeat'], array_keys($user->errors()));
+		$this->assertEquals(['pwd', 'pwd_repeat'], array_keys((array)$user->errors()));
 	}
 
 	/**
@@ -171,9 +171,8 @@ public function testValidateEmptyWithCurrentPassword() {
 		];
 		$this->Users->patchEntity($user, $data);
 		$is = $this->Users->save($user);
-		//debug($user->errors());
 		$this->assertFalse($is);
-		$this->assertEquals(['pwd', 'pwd_repeat', 'pwd_current'], array_keys($user->errors()));
+		$this->assertEquals(['pwd', 'pwd_repeat', 'pwd_current'], array_keys((array)$user->errors()));
 
 		$this->tearDown();
 		$this->setUp();
@@ -435,7 +434,67 @@ public function testValidateCurrent() {
 
 		// Validation errors triggered - as expected
 		$this->assertFalse($is);
-		$this->assertSame(['pwd', 'pwd_repeat', 'pwd_current'], array_keys($user->errors()));
+		$this->assertSame(['pwd', 'pwd_repeat', 'pwd_current'], array_keys((array)$user->errors()));
+	}
+
+	/**
+	 * Needs faking of pwd check...
+	 *
+	 * @return void
+	 */
+	public function testValidateCurrentOptional() {
+		$this->assertFalse($this->Users->behaviors()->has('Passwordable'));
+		$user = $this->Users->newEntity();
+		$data = [
+			'name' => 'xyz',
+			'password' => $this->hasher->hash('somepwd')];
+		$this->Users->patchEntity($user, $data);
+		$result = $this->Users->save($user);
+		$this->assertTrue(!empty($result));
+		$userCopy = clone($user);
+		$uid = $user->id;
+
+		$this->Users->removeBehavior('Passwordable');
+		$this->Users->addBehavior('Tools.Passwordable', ['current' => true, 'require' => false]);
+		$user = clone($userCopy);
+		$data = [
+			'name' => 'Yeah',
+			'current' => '',
+			'pwd' => '',
+			'pwd_repeat' => '',
+		];
+		$this->Users->patchEntity($user, $data);
+		$this->assertTrue($this->Users->behaviors()->has('Passwordable'));
+		$is = $this->Users->save($user);
+		$this->assertTrue((bool)$is);
+
+		$user = clone($userCopy);
+		$data = [
+			'name' => 'Yeah',
+			'pwd_current' => '',
+			'pwd' => '123456',
+			'pwd_repeat' => '123456'
+		];
+		$this->Users->patchEntity($user, $data);
+		$is = $this->Users->save($user);
+		$this->assertFalse($is);
+
+		$user = clone($userCopy);
+		$data = [
+			'name' => 'Yeah',
+			'pwd_current' => 'somepwd',
+			'pwd' => '123456',
+			'pwd_repeat' => '123456'
+		];
+		$user->accessible('*', false); // Mark all properties as protected
+		$user->accessible(['id'], true); // Allow id to be accessible by default
+		$user = $this->Users->patchEntity($user, $data, ['fields' => ['id']]);
+
+		$this->assertNotSame($is['password'], $user['password']);
+		$this->assertTrue($user->dirty('pwd'));
+
+		$is = $this->Users->save($user);
+		$this->assertTrue((bool)$is);
 	}
 
 	/**