fix(ext/node): fix inspect of CustomEvent of Node.js (#29668)

Author: kt3k

ext/node/polyfills/internal/event_target.mjs

@@ -4,6 +4,13 @@
 // TODO(petamoriken): enable prefer-primordials for node polyfills
 // deno-lint-ignore-file prefer-primordials
 
+import { primordials } from "ext:core/mod.js";
+const {
+  NumberIsInteger,
+  ObjectAssign,
+  SymbolFor,
+  SymbolToStringTag,
+} = primordials;
 import {
   ERR_EVENT_RECURSION,
   ERR_INVALID_ARG_TYPE,
@@ -105,7 +112,7 @@ class Event extends WebEvent {
       return name;
     }
 
-    const opts = Object.assign({}, options, {
+    const opts = ObjectAssign({}, options, {
       depth: NumberIsInteger(options.depth) ? options.depth - 1 : options.depth,
     });
 
@@ -316,6 +323,15 @@ Object.defineProperties(
     eventPhase: kEnumerableProperty,
     cancelBubble: kEnumerableProperty,
     stopPropagation: kEnumerableProperty,
+    // The parent class `WebEvent` has this field defined, which has greater
+    // precedence than Symbol.for('nodejs.util.inspect.custom') and shadow it.
+    // Overwriting it to `undefined` cancels the shadowing.
+    [SymbolFor("Deno.privateCustomInspect")]: {
+      value: undefined,
+      writable: true,
+      enumerable: false,
+      configurable: true,
+    },
   },
 );
 
@@ -340,6 +356,7 @@ class CustomEvent extends Event {
     }
     super(type, options);
     this[kDetail] = options?.detail ?? null;
+    this[SymbolToStringTag] = "CustomEvent";
   }
 
   /**
@@ -353,17 +370,6 @@ class CustomEvent extends Event {
   }
 }
 
-Object.defineProperties(CustomEvent.prototype, {
-  [Symbol.toStringTag]: {
-    __proto__: null,
-    writable: false,
-    enumerable: false,
-    configurable: true,
-    value: "CustomEvent",
-  },
-  detail: kEnumerableProperty,
-});
-
 class NodeCustomEvent extends Event {
   constructor(type, options) {
     super(type, options);
@@ -763,9 +769,7 @@ class EventTarget extends WebEventTarget {
     }
 
     const opts = ObjectAssign({}, options, {
-      depth: Number.isInteger(options.depth)
-        ? options.depth - 1
-        : options.depth,
+      depth: NumberIsInteger(options.depth) ? options.depth - 1 : options.depth,
     });
 
     return `${name} ${inspect({}, opts)}`;

tests/node_compat/config.jsonc

@@ -536,6 +536,7 @@
       "test-event-emitter-symbols.js",
       "test-event-target.js",
       "test-events-add-abort-listener.mjs",
+      "test-events-customevent.js",
       "test-events-getmaxlisteners.js",
       "test-events-list.js",
       "test-events-listener-count-with-listener.js",

tests/node_compat/runner/TODO.md

@@ -1,7 +1,7 @@
 <!-- deno-fmt-ignore-file -->
 # Remaining Node Tests
 
-1201 tests out of 3993 have been ported from Node 23.9.0 (30.08% ported, 70.52% remaining).
+1202 tests out of 3993 have been ported from Node 23.9.0 (30.10% ported, 70.50% remaining).
 
 NOTE: This file should not be manually edited. Please edit `tests/node_compat/config.json` and run `deno task setup` in `tests/node_compat/runner` dir instead.
 
@@ -743,7 +743,6 @@ NOTE: This file should not be manually edited. Please edit `tests/node_compat/co
 - [parallel/test-esm-loader-hooks-inspect-wait.js](https://github.com/nodejs/node/tree/v23.9.0/test/parallel/test-esm-loader-hooks-inspect-wait.js)
 - [parallel/test-eval-disallow-code-generation-from-strings.js](https://github.com/nodejs/node/tree/v23.9.0/test/parallel/test-eval-disallow-code-generation-from-strings.js)
 - [parallel/test-eventemitter-asyncresource.js](https://github.com/nodejs/node/tree/v23.9.0/test/parallel/test-eventemitter-asyncresource.js)
-- [parallel/test-events-customevent.js](https://github.com/nodejs/node/tree/v23.9.0/test/parallel/test-events-customevent.js)
 - [parallel/test-events-static-geteventlisteners.js](https://github.com/nodejs/node/tree/v23.9.0/test/parallel/test-events-static-geteventlisteners.js)
 - [parallel/test-eventsource-disabled.js](https://github.com/nodejs/node/tree/v23.9.0/test/parallel/test-eventsource-disabled.js)
 - [parallel/test-eventsource.js](https://github.com/nodejs/node/tree/v23.9.0/test/parallel/test-eventsource.js)