Fix setOperationId called in an operation transformer not working (#872)

* make sure not to override operation id set via `setOperationId` api

* Fix styling

---------

Co-authored-by: romalytvynenko <[email protected]>

Author: romalytvynenko

src/Generator.php

@@ -295,10 +295,18 @@ private function setUniqueOperationId(OpenApi $openApi)
         $names = new UniqueNamesOptionsCollection;
 
         $this->foreachOperation($openApi, function (Operation $operation) use ($names) {
+            if ($operation->operationId) {
+                return;
+            }
+
             $names->push($operation->getAttribute('operationId')); // @phpstan-ignore argument.type
         });
 
         $this->foreachOperation($openApi, function (Operation $operation, $index) use ($names) {
+            if ($operation->operationId) {
+                return;
+            }
+
             $name = $operation->getAttribute('operationId');
 
             $operation->setOperationId($names->getUniqueName($name, function (string $fallback) use ($index) { // @phpstan-ignore argument.type

tests/Generator/Operation/OperationIdTest.php

@@ -1,6 +1,11 @@
 <?php
 
+namespace Dedoc\Scramble\Tests\Generator\Request;
+
 use Dedoc\Scramble\Scramble;
+use Dedoc\Scramble\Support\Generator\Operation;
+use Dedoc\Scramble\Support\RouteInfo;
+use Illuminate\Routing\Controller;
 use Illuminate\Routing\Route;
 use Illuminate\Support\Facades\Route as RouteFacade;
 
@@ -86,3 +91,21 @@ public function a(): Illuminate\Http\Resources\Json\JsonResource
         return $this->unknown_fn();
     }
 }
+
+it('documents operation id with manual extension', function () {
+    Scramble::configure()->withOperationTransformers(function (Operation $operation, RouteInfo $routeInfo): void {
+        $operation->setOperationId('extensionOperationIdDocumentationTest');
+    });
+
+    $openApiDocument = generateForRoute(function () {
+        return RouteFacade::get('api/test', [ExtensionOperationIdDocumentationTestController::class, 'a']);
+    });
+
+    expect($openApiDocument['paths']['/test']['get'])
+        ->toHaveKey('operationId', 'extensionOperationIdDocumentationTest');
+});
+
+class ExtensionOperationIdDocumentationTestController extends Controller
+{
+    public function a() {}
+}