feat: support removeChild from parent on destroy (#275)

Author: ddubrava

libs/angular-yandex-maps-v3/src/lib/components/common/y-map-clusterer/y-map-clusterer.directive.spec.ts

@@ -156,4 +156,15 @@ describe('YMapClustererDirective', () => {
 
     expect(clustererInstance.update).toHaveBeenCalledWith(expect.objectContaining(props));
   });
+
+  it('should remove entity on destroy', async () => {
+    fixture.detectChanges();
+
+    // ymaps3.import is async, wait for it
+    await new Promise(process.nextTick);
+
+    fixture.destroy();
+
+    expect(mapInstance.removeChild).toHaveBeenCalledWith(clustererInstance);
+  });
 });

libs/angular-yandex-maps-v3/src/lib/components/common/y-map-clusterer/y-map-clusterer.directive.ts

@@ -183,6 +183,10 @@ export class YMapClustererDirective implements AfterContentInit, OnDestroy, OnCh
   }
 
   ngOnDestroy() {
+    if (this.clusterer) {
+      this.yMapComponent.map$.value?.removeChild(this.clusterer);
+    }
+
     this.destroy$.next();
     this.destroy$.complete();
   }

libs/angular-yandex-maps-v3/src/lib/components/common/y-map-default-marker/y-map-default-marker.directive.spec.ts

@@ -125,4 +125,15 @@ describe('YMapDefaultMarkerDirective', () => {
 
     expect(markerInstance.update).toHaveBeenCalledWith(props);
   });
+
+  it('should remove entity on destroy', async () => {
+    fixture.detectChanges();
+
+    // ymaps3.import is async, wait for it
+    await new Promise(process.nextTick);
+
+    fixture.destroy();
+
+    expect(mapInstance.removeChild).toHaveBeenCalledWith(markerInstance);
+  });
 });

libs/angular-yandex-maps-v3/src/lib/components/common/y-map-default-marker/y-map-default-marker.directive.ts

@@ -99,6 +99,10 @@ export class YMapDefaultMarkerDirective implements OnInit, OnDestroy, OnChanges
   }
 
   ngOnDestroy() {
+    if (this.marker) {
+      this.yMapComponent.map$.value?.removeChild(this.marker);
+    }
+
     this.destroy$.next();
     this.destroy$.complete();
   }

libs/angular-yandex-maps-v3/src/lib/components/common/y-map-feature-data-source/y-map-feature-data-source.directive.spec.ts

@@ -106,4 +106,11 @@ describe('YMapFeatureDataSourceDirective', () => {
 
     expect(sourceInstance.update).toHaveBeenCalledWith(props);
   });
+
+  it('should remove entity on destroy', async () => {
+    fixture.detectChanges();
+    fixture.destroy();
+
+    expect(mapInstance.removeChild).toHaveBeenCalledWith(sourceInstance);
+  });
 });

libs/angular-yandex-maps-v3/src/lib/components/common/y-map-feature-data-source/y-map-feature-data-source.directive.ts

@@ -77,6 +77,10 @@ export class YMapFeatureDataSourceDirective implements OnInit, OnDestroy, OnChan
   }
 
   ngOnDestroy() {
+    if (this.source) {
+      this.yMapComponent.map$.value?.removeChild(this.source);
+    }
+
     this.destroy$.next();
     this.destroy$.complete();
   }

libs/angular-yandex-maps-v3/src/lib/components/common/y-map-feature/y-map-feature.directive.spec.ts

@@ -118,4 +118,11 @@ describe('YMapFeatureDirective', () => {
 
     expect(featureInstance.update).toHaveBeenCalledWith(props);
   });
+
+  it('should remove entity on destroy', async () => {
+    fixture.detectChanges();
+    fixture.destroy();
+
+    expect(mapInstance.removeChild).toHaveBeenCalledWith(featureInstance);
+  });
 });

libs/angular-yandex-maps-v3/src/lib/components/common/y-map-feature/y-map-feature.directive.ts

@@ -98,6 +98,10 @@ export class YMapFeatureDirective implements OnInit, OnDestroy, OnChanges {
   }
 
   ngOnDestroy() {
+    if (this.feature) {
+      this.yMapComponent.map$.value?.removeChild(this.feature);
+    }
+
     this.destroy$.next();
     this.destroy$.complete();
   }

libs/angular-yandex-maps-v3/src/lib/components/common/y-map-hint/y-map-hint.directive.spec.ts

@@ -134,4 +134,15 @@ describe('YMapHintDirective', () => {
 
     expect(hintInstance.update).toHaveBeenCalledWith(props);
   });
+
+  it('should remove entity on destroy', async () => {
+    fixture.detectChanges();
+
+    // ymaps3.import is async, wait for it
+    await new Promise(process.nextTick);
+
+    fixture.destroy();
+
+    expect(mapInstance.removeChild).toHaveBeenCalledWith(hintInstance);
+  });
 });

libs/angular-yandex-maps-v3/src/lib/components/common/y-map-hint/y-map-hint.directive.ts

@@ -137,6 +137,10 @@ export class YMapHintDirective implements AfterContentInit, OnChanges, OnDestroy
   }
 
   ngOnDestroy() {
+    if (this.hint) {
+      this.yMapComponent.map$.value?.removeChild(this.hint);
+    }
+
     this.destroy$.next();
     this.destroy$.complete();
   }