Merge branch 'development' of https://github.com/dataplat/dbatools into pester_cleanup

Author: andreasjordan

public/Find-DbaDbGrowthEvent.ps1

@@ -181,7 +181,6 @@ function Find-DbaDbGrowthEvent {
                         FROM::fn_trace_gettable( @base_tracefilename, DEFAULT )
                         WHERE
                             [EventClass] IN ($eventClassFilter)
-                            AND [ServerName] = @@SERVERNAME
                             AND [DatabaseName] IN (_DatabaseList_)
                         ORDER BY [StartTime] DESC;
                     END

public/Get-DbaClientProtocol.ps1

@@ -66,7 +66,7 @@ function Get-DbaClientProtocol {
             if ( $server.FullComputerName ) {
                 $computer = $server.FullComputerName
                 Write-Message -Level Verbose -Message "Getting SQL Server namespace on $computer"
-                $namespace = Get-DbaCmObject -ComputerName $computer -Namespace root\Microsoft\SQLServer -Query "Select * FROM __NAMESPACE WHERE Name LIke 'ComputerManagement%'" -ErrorAction SilentlyContinue | Where-Object { (Get-DbaCmObject -ComputerName $computer -Namespace $("root\Microsoft\SQLServer\" + $_.Name) -ClassName ClientNetworkProtocol -ErrorAction SilentlyContinue).count -gt 0 } | Sort-Object Name -Descending | Select-Object -First 1
+                $namespace = Get-DbaCmObject -ComputerName $computer -Namespace root\Microsoft\SQLServer -Query "Select * FROM __NAMESPACE WHERE Name LIke 'ComputerManagement%'" -ErrorAction SilentlyContinue | Sort-Object Name -Descending | Select-Object -First 1
 
                 if ( $namespace.Name ) {
                     Write-Message -Level Verbose -Message "Getting Cim class ClientNetworkProtocol in Namespace $($namespace.Name) on $computer"

public/Install-DbaAgentAdminAlert.ps1

@@ -150,7 +150,7 @@ function Install-DbaAgentAdminAlert {
 
             if ($Operator) {
                 try {
-                    $newop = Get-DbaAgentOperator -SqlInstance $server
+                    $newop = Get-DbaAgentOperator -SqlInstance $server -Operator $Operator
                     if (-not $newop -and $OperatorEmail) {
                         if ($PSCmdlet.ShouldProcess($instance, "Creating operator $Operator with email $OperatorEmail")) {
                             Write-Message -Level Verbose -Message "Creating operator $Operator with email $OperatorEmail on $instance"
@@ -160,13 +160,14 @@ function Install-DbaAgentAdminAlert {
                                 Email       = $OperatorEmail
                             }
                             $newop = New-DbaAgentOperator @parms
+                            $null = $server.JobServer.Operators.Refresh()
+                            $null = $server.JobServer.Refresh()
 
                             if (-not $newop) {
                                 $parms = @{
-                                    Message     = "Failed to create operator $Operator with email $OperatorEmail on $instance"
-                                    Target      = $instance
-                                    Continue    = $true
-                                    ErrorRecord = $PSItem
+                                    Message  = "Failed to create operator $Operator with email $OperatorEmail on $instance"
+                                    Target   = $instance
+                                    Continue = $true
                                 }
                                 Stop-Function @parms
                             }
@@ -191,10 +192,9 @@ function Install-DbaAgentAdminAlert {
 
                             if (-not $newcat) {
                                 $parms = @{
-                                    Message     = "Failed to create category $Category on $instance"
-                                    Target      = $instance
-                                    Continue    = $true
-                                    ErrorRecord = $PSItem
+                                    Message  = "Failed to create category $Category on $instance"
+                                    Target   = $instance
+                                    Continue = $true
                                 }
                                 Stop-Function @parms
                             }
@@ -288,7 +288,7 @@ function Install-DbaAgentAdminAlert {
                     if ($PSCmdlet.ShouldProcess($instance, "Adding the alert $name")) {
                         try {
                             # Supply either a non-zero message ID, non-zero severity, non-null performance condition, or non-null WMI namespace and query.
-                            $null = New-DbaAgentAlert @parms
+                            $null = New-DbaAgentAlert @parms -EnableException
                         } catch {
                             Stop-Function -Message "Something went wrong creating the alert $name on $instance" -Target $name -Continue -ErrorRecord $_
                         }

public/Remove-DbaDatabaseSafely.ps1

@@ -365,7 +365,7 @@ function Remove-DbaDatabaseSafely {
 
                     ## Create a Job Category
                     if (!(Get-DbaAgentJobCategory -SqlInstance $destination -SqlCredential $DestinationSqlCredential -Category $categoryname)) {
-                        New-DbaAgentJobCategory -SqlInstance $destination -SqlCredential $DestinationSqlCredential -Category $categoryname -EnableException
+                        $null = New-DbaAgentJobCategory -SqlInstance $destination -SqlCredential $DestinationSqlCredential -Category $categoryname -EnableException
                     }
 
                     try {

public/Test-DbaDiskAllocation.ps1

@@ -85,9 +85,6 @@ function Test-DbaDiskAllocation {
 
             try {
                 Write-Message -Level Verbose -Message "Getting disk information from $computer."
-
-                # $query = "Select Label, BlockSize, Name from Win32_Volume WHERE FileSystem='NTFS'"
-                # $disks = Get-WmiObject -ComputerName $ipaddr -Query $query | Sort-Object -Property Name
                 $disks = Get-CimInstance -CimSession $CIMsession -ClassName win32_volume -Filter "FileSystem='NTFS'" -ErrorAction Stop | Sort-Object -Property Name
             } catch {
                 Stop-Function -Message "Can't connect to WMI on $computer."
@@ -106,9 +103,9 @@ function Test-DbaDiskAllocation {
                     Write-Message -Level Verbose -Message "Found instance $instanceName."
 
                     if ($instance -eq 'MSSQLSERVER') {
-                        $SqlInstances += $ipaddr
+                        $SqlInstances += $computer
                     } else {
-                        $SqlInstances += "$ipaddr\$instance"
+                        $SqlInstances += "$computer\$instance"
                     }
                 }
                 $sqlcount = $SqlInstances.Count
@@ -182,7 +179,6 @@ function Test-DbaDiskAllocation {
         foreach ($computer in $ComputerName) {
 
             $computer = Resolve-DbaNetworkName -ComputerName $computer -Credential $Credential
-            $ipaddr = $computer.IpAddress
             $Computer = $computer.FullComputerName
 
             if (!$Computer) {