Normalise Execution Response (clean backend interfaces)

[varun-edachali-dbx]

What type of PR is this?

• Refactor

Description

The overall goal is to clean up the backend interfaces to facilitate the introduction of the SEA client with minimal overhead.

• Earlier, ExecuteResponse was used as a Thrift aligned object for the return type of execution commands. Now, it is used as a normalised object store for common state that is passed as a parameter to the ResultSet type to prevent too many primitive types.
• More common functionality and attributes have been pulled up to the common base ResultSet class.
• Move Queue initialisation away from the execution phase, instead doing it directly in the ResultSet constructor, to better decouple the exec and fetch phases.

               # Before                                       # After
                                                
ExecuteResponse = namedtuple(                   @dataclass
  "ExecuteResponse",                            class ExecuteResponse:
  "command_handle                                 command_id: CommandId
   status                                         status: CommandState
   description                                    description: Optional[List[Tuple]] = None
   has_more_rows                                 
   arrow_queue                                    
   has_been_closed_server_side                    has_been_closed_server_side: bool = False
   lz4_compressed                                 lz4_compressed: bool = True
   is_staging_operation                           is_staging_operation: bool = False
   arrow_schema_bytes"                            arrow_schema_bytes: Optional[bytes] = None
)                                                 result_format

How is this tested?

• Unit tests
• E2E Tests
• Manually
• N/A

Related Tickets & Documents

https://docs.google.com/document/d/1Y-eXLhNqqhrMVGnOlG8sdFrCxBTN1GdQvuKG4IfHmo0/edit?usp=sharing

[samikshya-db]

arrow_schema_bytes - this is also specific to thrift flow, isn't it?

[varun-edachali-dbx]

arrow_schema_bytes - this is also specific to thrift flow, isn't it?

My understanding is that it will be used by SEA for the construction of the arrow table for the EXTERNAL_LINKS disposition. Is that right?

[jayantsing-db]

minor comments inline. rest lgtm.

[samikshya-db]

My understanding is that it will be used by SEA for the construction of the arrow table for the EXTERNAL_LINKS disposition. Is that right?

This is not correct. But given the fact that we have discussed the mental model with J on this offline, i am good. Approving.