[Suggestion] - Change the name of dbName to something else ?

[robinportigliatti]

Hello,

I am not sure if it's really pgwatch or prometheus related .

For this metric:

metrics_db_stats_invalid_indexes{dbname="Instance_test_postgres", instance="pgwatch:9187", job="pgwatch", real_dbname="postgres", sys_id="7535770844231086118"}

In instance I have pgwatch:9187 and I find it weird. Since pgwatch is not really an instance as properly say.
And since we can configure multiple sources, it might be more pleasant to update those fields.

I would find it much easier to understand something like this:

metrics_db_stats_invalid_indexes{instance="Instance_test", source="pgwatch:9187", job="pgwatch", dbname="postgres", sys_id="7535770844231086118"}

What do you think ?

Robin,

[pashagolub]

Hello. I feel your pain. But we cannot change it easily, otherwise we will break dozens of deployments and dashboards.

[robinportigliatti]

Not a real problem in my opinion. And you are right, this should be realized properly.

If it is a question about time, I can do it. No worries.