Skip to content

Commit 9cb82fc

Browse files
fixed bug where marketing page included Unity numbers in the metrics
1 parent dda85ff commit 9cb82fc

File tree

2 files changed

+13
-7
lines changed

2 files changed

+13
-7
lines changed

app_pages/Marketing_Data.py

Lines changed: 12 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -56,29 +56,34 @@
5656
col1, col2, col3 = st.columns(3)
5757

5858
LR = metrics.get_totals_by_metric(
59-
daterange, countries_list, stat="LR", language=language
59+
daterange=daterange, countries_list=countries_list, stat="LR", language=language,app="CR"
6060
)
61+
62+
RA = metrics.get_totals_by_metric(
63+
daterange=daterange, countries_list=countries_list, stat="RA", language=language,app="CR"
64+
)
65+
6166
col1.metric(label="Learners Reached", value=prettify(int(LR)))
6267

6368
total = metrics.get_totals_by_metric(
64-
daterange, countries_list, "LA", language=language
69+
daterange, countries_list, "LA", language=language,app="CR"
6570
)
6671
col2.metric(label="Learners Acquired", value=prettify(int(total)))
6772

6873
total = metrics.get_totals_by_metric(
69-
daterange, countries_list, "RA", language=language
74+
daterange, countries_list, "RA", language=language,app="CR"
7075
)
7176
col3.metric(label="Readers Acquired", value=prettify(int(total)))
7277

7378
total = metrics.get_totals_by_metric(
74-
daterange, countries_list, "GC", language=language
79+
daterange, countries_list, "GC", language=language,app="CR"
7580
)
7681
col1.metric(label="Games Completed", value=prettify(int(total)))
7782

78-
total = metrics.get_GPP_avg(daterange, countries_list, language=language)
83+
total = metrics.get_GPP_avg(daterange, countries_list, language=language,app="CR")
7984
col2.metric(label="Game Progress Percent", value=f"{total:.2f}%")
8085

81-
total = metrics.get_GC_avg(daterange, countries_list, language=language)
86+
total = metrics.get_GC_avg(daterange, countries_list, language=language,app="CR")
8287
col3.metric(label="Game Completion Avg", value=f"{total:.2f}%")
8388

8489
df_campaigns_all = st.session_state["df_campaigns_all"]
@@ -89,6 +94,7 @@
8994
col1.metric(label="Cost", value=f"${prettify(int(cost))}")
9095

9196
col2.metric(label="LRC", value=f"${cost/LR:.2f}" if LR != 0 else "N/A")
97+
col3.metric(label="RAC", value=f"${cost/RA:.2f}" if RA != 0 else "N/A")
9298
# LR vs LRC chart
9399
st.divider()
94100

metrics.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -536,7 +536,7 @@ def get_totals_per_month(daterange, stat, countries_list, language):
536536

537537
# Get totals within the clipped date range
538538
total = get_totals_by_metric(
539-
daterange=clipped_range, countries_list=countries_list, stat=stat, language=language
539+
daterange=clipped_range, countries_list=countries_list, stat=stat, language=language,app="CR"
540540
)
541541

542542
# Filter campaigns based on the clipped date range

0 commit comments

Comments
 (0)