internal/ci: remove debug logging of commit message

The original logging could, at very low risk, have introduced a
potential security issue, as the logging did not disable shell
interpolation of the contents of the commit message. In any case the
logging is not required, so remove it.

We also remove the now-unused workflowDispatch step template.

Signed-off-by: Paul Jolly <[email protected]>
Change-Id: I4a3b8cfef28356350a2fb72e19ca7b6661244084
Reviewed-on: https://review.gerrithub.io/c/cue-lang/cue/+/1196926
Reviewed-by: Roger Peppe <[email protected]>
TryBot-Result: CUEcueckoo <[email protected]>
Unity-Result: CUE porcuepine <[email protected]>

Author: myitcv

.github/workflows/evict_caches.yml

@@ -44,16 +44,7 @@ jobs:
           Dispatch-Trailer: {"type":"'))
         name: Check we don't have Dispatch-Trailer on a protected branch
         run: |-
-          echo "github.event.head_commit.message contains Dispatch-Trailer"
-          echo "github.event.head_commit.message value"
-          cat <<EOD
-          ${{ github.event.head_commit.message }}
-          EOD
-          echo "containsDispatchTrailer expression"
-          cat <<EOD
-          (contains(github.event.head_commit.message, '
-          Dispatch-Trailer: {"type":"'))
-          EOD
+          echo "github.event.head_commit.message contains Dispatch-Trailer but we are on a protected branch"
           false
       - name: Delete caches
         run: |-

.github/workflows/release.yml

@@ -51,16 +51,7 @@ jobs:
           Dispatch-Trailer: {"type":"'))
         name: Check we don't have Dispatch-Trailer on a protected branch
         run: |-
-          echo "github.event.head_commit.message contains Dispatch-Trailer"
-          echo "github.event.head_commit.message value"
-          cat <<EOD
-          ${{ github.event.head_commit.message }}
-          EOD
-          echo "containsDispatchTrailer expression"
-          cat <<EOD
-          (contains(github.event.head_commit.message, '
-          Dispatch-Trailer: {"type":"'))
-          EOD
+          echo "github.event.head_commit.message contains Dispatch-Trailer but we are on a protected branch"
           false
       - name: Install Go
         uses: actions/setup-go@v5

.github/workflows/trybot.yml

@@ -64,16 +64,7 @@ jobs:
           Dispatch-Trailer: {"type":"'))
         name: Check we don't have Dispatch-Trailer on a protected branch
         run: |-
-          echo "github.event.head_commit.message contains Dispatch-Trailer"
-          echo "github.event.head_commit.message value"
-          cat <<EOD
-          ${{ github.event.head_commit.message }}
-          EOD
-          echo "containsDispatchTrailer expression"
-          cat <<EOD
-          (contains(github.event.head_commit.message, '
-          Dispatch-Trailer: {"type":"'))
-          EOD
+          echo "github.event.head_commit.message contains Dispatch-Trailer but we are on a protected branch"
           false
       - name: Install Go
         uses: actions/setup-go@v5

internal/ci/base/github.cue

@@ -91,15 +91,7 @@ checkoutCode: {
 			name: "Check we don't have \(dispatchTrailer) on a protected branch"
 			if:   "\(isProtectedBranch) && \(containsDispatchTrailer)"
 			run:  """
-				echo "\(_dispatchTrailerVariable) contains \(dispatchTrailer)"
-				echo "\(_dispatchTrailerVariable) value"
-				cat <<EOD
-				${{ \(_dispatchTrailerVariable) }}
-				EOD
-				echo "containsDispatchTrailer expression"
-				cat <<EOD
-				\(containsDispatchTrailer)
-				EOD
+				echo "\(_dispatchTrailerVariable) contains \(dispatchTrailer) but we are on a protected branch"
 				false
 				"""
 		},
@@ -297,24 +289,6 @@ repositoryDispatch: json.#step & {
 			"""#
 }
 
-workflowDispatch: json.#step & {
-	#githubRepositoryPath:         *githubRepositoryPath | string
-	#botGitHubUserTokenSecretsKey: *botGitHubUserTokenSecretsKey | string
-	#workflowID:                   string
-
-	// params are defined per https://docs.github.com/en/rest/actions/workflows?apiVersion=2022-11-28#create-a-workflow-dispatch-event
-	#params: *{
-		ref: defaultBranch
-	} | _
-
-	_curlGitHubAPI: curlGitHubAPI & {#tokenSecretsKey: #botGitHubUserTokenSecretsKey, _}
-
-	name: string
-	run:  #"""
-			\#(_curlGitHubAPI) --fail --request POST --data-binary \#(strconv.Quote(encjson.Marshal(#params))) https://api.github.com/repos/\#(#githubRepositoryPath)/actions/workflows/\#(#workflowID)/dispatches
-			"""#
-}
-
 // dispatchTrailer is the trailer that we use to pass information in a commit
 // when triggering workflow events in other GitHub repos.
 //