cue/ast: allow use of Embed in NewStruct

Eventually &ast.EmbedDecl may go. Using Embed
allows for a smooth transition, rather than supporting
EmbedDecl directly. It is also more convenient.

Change-Id: Iec869ff00bf7e11acbce3ed07a41a6fee2934423
Reviewed-on: https://cue-review.googlesource.com/c/cue/+/6562
Reviewed-by: CUE cueckoo <[email protected]>
Reviewed-by: Marcel van Lohuizen <[email protected]>

Author: mpvl

cue/ast/ast.go

@@ -520,6 +520,9 @@ func NewStruct(fields ...interface{}) *StructLit {
 		case *LetClause:
 			s.Elts = append(s.Elts, x)
 			continue
+		case *embedding:
+			s.Elts = append(s.Elts, (*EmbedDecl)(x))
+			continue
 		case Label:
 			label = x
 		case string:
@@ -561,6 +564,13 @@ func NewStruct(fields ...interface{}) *StructLit {
 	return s
 }
 
+// Embed can be used in conjunction with NewStruct to embed values.
+func Embed(x Expr) *embedding {
+	return (*embedding)(&EmbedDecl{Expr: x})
+}
+
+type embedding EmbedDecl
+
 // A ListLit node represents a literal list.
 type ListLit struct {
 	Lbrack token.Pos // position of "["

cue/ast/astutil/sanitize.go

@@ -136,7 +136,7 @@ func (z *sanitizer) unshadow(parent ast.Node, base string, link ast.Node) string
 		case *ast.StructLit:
 			decls = &x.Elts
 		default:
-			panic("impossible scope")
+			panic(fmt.Sprintf("impossible scope type %T", parent))
 		}
 
 		i := 0