encoding/jsonschema: CRD metadata field is not required

The `metadata` field should not be treated as required
when producing CRDs.

Signed-off-by: Roger Peppe <[email protected]>
Change-Id: I24ba87391fda9a7fa390a07d86afe761324313bb
Reviewed-on: https://review.gerrithub.io/c/cue-lang/cue/+/1214630
Reviewed-by: Daniel Martí <[email protected]>
Unity-Result: CUE porcuepine <[email protected]>
TryBot-Result: CUEcueckoo <[email protected]>

Author: rogpeppe

encoding/jsonschema/constraints_object.go

@@ -159,7 +159,7 @@ func constraintEmbeddedResource(key string, n cue.Value, s *state) {
 	s.builder.put(resourceDefinitionPath, ast.NewStruct(
 		"apiVersion", token.NOT, ast.NewIdent("string"),
 		"kind", token.NOT, ast.NewIdent("string"),
-		"metadata", token.NOT, ast.NewStruct(&ast.Ellipsis{}),
+		"metadata", token.OPTION, ast.NewStruct(&ast.Ellipsis{}),
 	), nil)
 	refExpr, err := s.builder.getRef(resourceDefinitionPath)
 	if err != nil {

encoding/jsonschema/testdata/txtar/crd_embeddedresource.txtar

@@ -71,7 +71,7 @@ r2?: {
 _embeddedResource: {
 	apiVersion!: string
 	kind!:       string
-	metadata!: {
+	metadata?: {
 		...
 	}
 }

encoding/jsonschema/testdata/txtar/crd_intorstring.txtar

@@ -35,7 +35,7 @@ spec?: int | string
 _embeddedResource: {
 	apiVersion!: string
 	kind!:       string
-	metadata!: {
+	metadata?: {
 		...
 	}
 }

encoding/jsonschema/testdata/txtar/crd_intorstring_with_anyof.txtar

@@ -41,7 +41,7 @@ spec?: matchN(>=1, [int, string]) & (int | string)
 _embeddedResource: {
 	apiVersion!: string
 	kind!:       string
-	metadata!: {
+	metadata?: {
 		...
 	}
 }

encoding/jsonschema/testdata/txtar/crd_preserve_unknown.txtar

@@ -97,7 +97,7 @@ pruning?: {
 _embeddedResource: {
 	apiVersion!: string
 	kind!:       string
-	metadata!: {
+	metadata?: {
 		...
 	}
 }

encoding/jsonschema/testdata/txtar/crd_simple.txtar

@@ -38,7 +38,7 @@ spec?: {
 _embeddedResource: {
 	apiVersion!: string
 	kind!:       string
-	metadata!: {
+	metadata?: {
 		...
 	}
 }