internal/core/adt: also create embed scope for disjunctions

Doing so increases the counters, but if it is
not done, fields alongside the disjunction may
be perceived to be in the wrong scope.

Fixes #3964

Signed-off-by: Marcel van Lohuizen <[email protected]>
Change-Id: Ie6f4347ce2a2703b7a7ce0d6c91c84d8e26cd7cc
Reviewed-on: https://review.gerrithub.io/c/cue-lang/cue/+/1216871
Unity-Result: CUE porcuepine <[email protected]>
TryBot-Result: CUEcueckoo <[email protected]>
Reviewed-by: Daniel Martí <[email protected]>

Author: mpvl

cue/testdata/benchmarks/inlinedisjunction.txtar

@@ -24,8 +24,8 @@ Unifications: 16
 Conjuncts:    113
 Disjuncts:    58
 
-CloseIDElems: 22
-NumCloseIDs: 3
+CloseIDElems: 312
+NumCloseIDs: 23
 -- out/eval --
 (struct){
   #def: (#struct){ |((#struct){
@@ -66,8 +66,8 @@ diff old new
 +Conjuncts:    113
 +Disjuncts:    58
 +
-+CloseIDElems: 22
-+NumCloseIDs: 3
++CloseIDElems: 312
++NumCloseIDs: 23
 -- out/eval/stats --
 Leaks:  0
 Freed:  4674

cue/testdata/benchmarks/listdedup.txtar

@@ -43,8 +43,8 @@ Unifications: 40
 Conjuncts:    98
 Disjuncts:    24
 
-CloseIDElems: 956
-NumCloseIDs: 18
+CloseIDElems: 1206
+NumCloseIDs: 22
 -- out/evalalpha --
 (struct){
   A: (#struct){ |((#struct){
@@ -486,8 +486,8 @@ diff old new
 +Conjuncts:    98
 +Disjuncts:    24
 +
-+CloseIDElems: 956
-+NumCloseIDs: 18
++CloseIDElems: 1206
++NumCloseIDs: 22
 -- out/eval/stats --
 Leaks:  0
 Freed:  24096

cue/testdata/builtins/closed.txtar

@@ -102,8 +102,8 @@ Unifications: 230
 Conjuncts:    360
 Disjuncts:    12
 
-CloseIDElems: 1231
-NumCloseIDs: 88
+CloseIDElems: 2194
+NumCloseIDs: 106
 -- diff/-out/evalalpha/stats<==>+out/eval/stats --
 diff old new
 --- old
@@ -128,8 +128,8 @@ diff old new
 +Conjuncts:    360
 +Disjuncts:    12
 +
-+CloseIDElems: 1231
-+NumCloseIDs: 88
++CloseIDElems: 2194
++NumCloseIDs: 106
 -- out/eval/stats --
 Leaks:  61
 Freed:  214

cue/testdata/comprehensions/pushdown.txtar

@@ -2326,8 +2326,8 @@ Unifications: 638
 Conjuncts:    1093
 Disjuncts:    48
 
-CloseIDElems: 1779
-NumCloseIDs: 290
+CloseIDElems: 1815
+NumCloseIDs: 292
 -- diff/-out/evalalpha/stats<==>+out/eval/stats --
 diff old new
 --- old
@@ -2355,8 +2355,8 @@ diff old new
 +Conjuncts:    1093
 +Disjuncts:    48
 +
-+CloseIDElems: 1779
-+NumCloseIDs: 290
++CloseIDElems: 1815
++NumCloseIDs: 292
 -- out/eval/stats --
 Leaks:  74
 Freed:  602