mod/modpkgload: capture faulty behaviour of pkg.fromExternal

Modify test to capture the faulty behaviour.

Signed-off-by: Matthew Sackman <[email protected]>
Change-Id: Ie4961f29a990c7dff13d92ee1763ac5302ac6041
Reviewed-on: https://review.gerrithub.io/c/cue-lang/cue/+/1217736
TryBot-Result: CUEcueckoo <[email protected]>
Reviewed-by: Roger Peppe <[email protected]>

Author: cuematthew

internal/mod/modpkgload/pkgload_test.go

@@ -77,6 +77,7 @@ func TestLoadPackages(t *testing.T) {
 						printf("\tmissing: %v\n", errors.As(pkg.Error(), new(*ImportMissingError)))
 					} else {
 						printf("\tmod: %v\n", pkg.Mod())
+						printf("\texternal: %v\n", pkg.FromExternalModule())
 						// Sanity check that the module file is available at pkg.ModRoot.
 						_, err := fs.Stat(pkg.ModRoot().FS, path.Join(pkg.ModRoot().Dir, "cue.mod/module.cue"))
 						qt.Assert(t, qt.IsNil(err), qt.Commentf("pkg %q; mod root: %#v", pkg.ImportPath(), pkg.ModRoot()))

internal/mod/modpkgload/testdata/localpackage.txtar

@@ -7,12 +7,14 @@ main.test@v0:main
 main.test@v0:main
 	flags: inAll,isRoot,fromRoot,importsLoaded
 	mod: main.test@v0
+	external: true
 	location: .
 	imports:
 		other.com/blah
 other.com/blah
 	flags: inAll,isRoot,fromRoot,importsLoaded
 	mod: local
+	external: true
 	location: cue.mod/gen/other.com/blah
 -- main.cue --
 package main

internal/mod/modpkgload/testdata/localpackageambiguous.txtar

@@ -15,12 +15,14 @@ main.test@v0:main
 main.test@v0:main
 	flags: inAll,isRoot,fromRoot,importsLoaded
 	mod: main.test@v0
+	external: true
 	location: .
 	imports:
 		example.com/blah
 example.com/blah
 	flags: inAll,isRoot,fromRoot,importsLoaded
 	mod: local
+	external: true
 	location: cue.mod/gen/example.com/blah
 -- test1/initial-requirements --
 main.test@v0
@@ -32,6 +34,7 @@ main.test@v0:main
 main.test@v0:main
 	flags: inAll,isRoot,fromRoot,importsLoaded
 	mod: main.test@v0
+	external: true
 	location: .
 	imports:
 		example.com/blah

internal/mod/modpkgload/testdata/localpackagemultipledirs.txtar

@@ -7,12 +7,14 @@ main.test@v0:main
 main.test@v0:main
 	flags: inAll,isRoot,fromRoot,importsLoaded
 	mod: main.test@v0
+	external: true
 	location: .
 	imports:
 		other.com/blah
 other.com/blah
 	flags: inAll,isRoot,fromRoot,importsLoaded
 	mod: local
+	external: true
 	location: cue.mod/gen/other.com/blah
 	location: cue.mod/usr/other.com/blah
 	location: cue.mod/pkg/other.com/blah

internal/mod/modpkgload/testdata/multidir.txtar

@@ -8,12 +8,14 @@ main.test@v0:main
 main.test@v0:main
 	flags: inAll,isRoot,fromRoot,importsLoaded
 	mod: main.test@v0
+	external: true
 	location: .
 	imports:
 		example.com/blah@v0
 example.com/blah@v0
 	flags: inAll,isRoot,fromRoot,importsLoaded
 	mod: [email protected]
+	external: true
 	location: _registry/example.com_v0.0.1/blah
 	imports:
 		foo.com/bar/hello/goodbye@v0

internal/mod/modpkgload/testdata/nocuefiles.txtar

@@ -8,6 +8,7 @@ main.test@v0:main
 main.test@v0:main
 	flags: inAll,isRoot,fromRoot,importsLoaded
 	mod: main.test@v0
+	external: true
 	location: .
 	imports:
 		example.com/blah@v0

internal/mod/modpkgload/testdata/packagegranularity.txtar

@@ -10,6 +10,7 @@ main.test@v0:main
 main.test@v0:main
 	flags: inAll,isRoot,fromRoot,importsLoaded
 	mod: main.test@v0
+	external: true
 	location: .
 	imports:
 		example.com/blah@v0
@@ -28,18 +29,21 @@ main.test@v0:main
 main.test@v0:main
 	flags: inAll,isRoot,fromRoot,importsLoaded
 	mod: main.test@v0
+	external: true
 	location: .
 	imports:
 		example.com/blah@v0
 example.com/blah@v0
 	flags: inAll,isRoot,fromRoot,importsLoaded
 	mod: [email protected]
+	external: true
 	location: _registry/example.com_v0.0.1/blah
 	imports:
 		foo.com/bar/hello/goodbye@v0
 foo.com/bar/hello/goodbye@v0
 	flags: inAll,isRoot,fromRoot,importsLoaded
 	mod: foo.com/[email protected]
+	external: true
 	location: _registry/foo.com_bar_v0.0.1/hello/goodbye
 -- main.cue --
 package main

internal/mod/modpkgload/testdata/simple.txtar

@@ -7,6 +7,7 @@ main.test@v0:main
 main.test@v0:main
 	flags: inAll,isRoot,fromRoot,importsLoaded
 	mod: main.test@v0
+	external: true
 	location: .
 	imports:
 		example.com/blah@v0
@@ -24,12 +25,14 @@ main.test@v0:main
 main.test@v0:main
 	flags: inAll,isRoot,fromRoot,importsLoaded
 	mod: main.test@v0
+	external: true
 	location: .
 	imports:
 		example.com/blah@v0
 example.com/blah@v0
 	flags: inAll,isRoot,fromRoot,importsLoaded
 	mod: [email protected]
+	external: true
 	location: _registry/example.com_v0.0.1/blah
 	imports:
 		foo.com/bar/hello/goodbye@v0

internal/mod/modpkgload/testdata/withdefaultmajorversions.txtar

@@ -9,12 +9,14 @@ example.com@v0
 main.test@v0:main
 	flags: inAll,isRoot,fromRoot,importsLoaded
 	mod: main.test@v0
+	external: true
 	location: .
 	imports:
 		example.com/blah
 example.com/blah
 	flags: inAll,isRoot,fromRoot,importsLoaded
 	mod: [email protected]
+	external: true
 	location: _registry/example.com_v0.0.1/blah
 	imports:
 		foo.com/bar/hello/goodbye@v0