internal/core/adt: add tests for 3946

Issue #3946

Signed-off-by: Marcel van Lohuizen <[email protected]>
Change-Id: I24459e8882ad34d82799a445e84f5d61089fd33e
Reviewed-on: https://review.gerrithub.io/c/cue-lang/cue/+/1216022
TryBot-Result: CUEcueckoo <[email protected]>
Reviewed-by: Daniel Martí <[email protected]>
Unity-Result: CUE porcuepine <[email protected]>
Reviewed-on: https://review.gerrithub.io/c/cue-lang/cue/+/1216576
Reviewed-by: Roger Peppe <[email protected]>

Author: mpvl

cue/testdata/eval/issue3919.txtar

@@ -53,16 +53,31 @@ issue3931: full: {
 		expr?: [...string]
 	}
 }
+-- issue3946.cue --
+issue3946: reduced:{
+	out: [for _, v in _inputs { v }]
+	_inputs: [_]: {
+		doExtra?: bool
+		if doExtra != _|_ {
+			if true {
+				extra: "yes"
+			}
+		}
+	}
+	if true {
+		_inputs: input1: name: "input1"
+	}
+}
 -- out/eval/stats --
-Leaks:  7
-Freed:  44
-Reused: 38
-Allocs: 13
-Retain: 3
+Leaks:  10
+Freed:  51
+Reused: 45
+Allocs: 16
+Retain: 6
 
-Unifications: 47
-Conjuncts:    73
-Disjuncts:    54
+Unifications: 57
+Conjuncts:    86
+Disjuncts:    67
 -- out/evalalpha --
 (struct){
   full: (struct){
@@ -77,6 +92,16 @@ Disjuncts:    54
     a: (int){ 30080 }
     port: (int){ |(*(int){ 30080 }, (int){ int }) }
   }
+  issue3946: (struct){
+    reduced: (_|_){
+      // [incomplete] issue3946.reduced._inputs.input1.name: cyclic reference to field input1:
+      //     ./issue3946.cue:11:2
+      out: (#list){
+      }
+      _inputs: (struct){
+      }
+    }
+  }
   issue3931: (struct){
     full: (struct){
       bar: (struct){
@@ -146,7 +171,29 @@ Disjuncts:    54
 diff old new
 --- old
 +++ new
-@@ -45,10 +45,7 @@
+@@ -12,18 +12,12 @@
+     port: (int){ |(*(int){ 30080 }, (int){ int }) }
+   }
+   issue3946: (struct){
+-    reduced: (struct){
++    reduced: (_|_){
++      // [incomplete] issue3946.reduced._inputs.input1.name: cyclic reference to field input1:
++      //     ./issue3946.cue:11:2
+       out: (#list){
+-        0: (struct){
+-          name: (string){ "input1" }
+-          doExtra?: (bool){ bool }
+-        }
+       }
+       _inputs: (struct){
+-        input1: (struct){
+-          name: (string){ "input1" }
+-          doExtra?: (bool){ bool }
+-        }
+       }
+     }
+   }
+@@ -61,10 +55,7 @@
      foo: (struct){
        fooData: (struct){
          total: (struct){
@@ -158,7 +205,7 @@ diff old new
          }
          _hidden: (struct){
            extra: (struct){
-@@ -56,12 +53,7 @@
+@@ -72,12 +63,7 @@
          }
        }
        shared: (struct){
@@ -186,6 +233,22 @@ diff old new
     a: (int){ 30080 }
     port: (int){ |(*(int){ 30080 }, (int){ int }) }
   }
+  issue3946: (struct){
+    reduced: (struct){
+      out: (#list){
+        0: (struct){
+          name: (string){ "input1" }
+          doExtra?: (bool){ bool }
+        }
+      }
+      _inputs: (struct){
+        input1: (struct){
+          name: (string){ "input1" }
+          doExtra?: (bool){ bool }
+        }
+      }
+    }
+  }
   issue3931: (struct){
     full: (struct){
       bar: (struct){
@@ -281,6 +344,35 @@ diff old new
     port: (int|*30080)
   }
 }
+--- issue3946.cue
+{
+  issue3946: {
+    reduced: {
+      out: [
+        for _, v in 〈1;_inputs〉 {
+          〈1;v〉
+        },
+      ]
+      _inputs: {
+        [_]: {
+          doExtra?: bool
+          if (〈0;doExtra〉 != _|_(explicit error (_|_ literal) in source)) {
+            if true {
+              extra: "yes"
+            }
+          }
+        }
+      }
+      if true {
+        _inputs: {
+          input1: {
+            name: "input1"
+          }
+        }
+      }
+    }
+  }
+}
 --- let.cue
 {
   issue3931: {