pkg/path/testdata: adapt Go implementation

remove build tags and allow support for multiple OSes

Notes:
- evaluation is still fully hermetic
- many functions may default to Unix by default
- VolumeName defaults to Windows
- Resolve was added instead of Abs. The latter requires
  a Getwd(), which wouldn't be hermetic. We could also
  overload Join, and change its semantics, but this seems
  a bit error-prone.
- In windows both \ and / are interpreted as slashes in
  some contexts. It is therefore important to distinguish
  between using Separator and IsSeparator.
- Note the super-cool tests. :)

Questions:
- Should VolumeName even take an OS argument?

Change-Id: I080bee599700a98e6019ca0666f72b4a59ba8da1
Reviewed-on: https://cue-review.googlesource.com/c/cue/+/7845
Reviewed-by: Marcel van Lohuizen <[email protected]>

Author: mpvl

pkg/path/testdata/example_nix_test.go

@@ -1,18 +1,31 @@
+// Copyright 2020 CUE Authors
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//     http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
 // Copyright 2013 The Go Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style
 // license that can be found in the LICENSE file.
 
-// +build !windows,!plan9
-
-package filepath_test
+package path_test
 
 import (
 	"fmt"
-	"path/filepath"
+
+	"cuelang.org/go/pkg/path"
 )
 
 func ExampleSplitList() {
-	fmt.Println("On Unix:", filepath.SplitList("/a/b/c:/usr/bin"))
+	fmt.Println("On Unix:", path.SplitList("/a/b/c:/usr/bin", path.Unix))
 	// Output:
 	// On Unix: [/a/b/c /usr/bin]
 }
@@ -27,7 +40,7 @@ func ExampleRel() {
 
 	fmt.Println("On Unix:")
 	for _, p := range paths {
-		rel, err := filepath.Rel(base, p)
+		rel, err := path.Rel(base, p, path.Unix)
 		fmt.Printf("%q: %q %v\n", p, rel, err)
 	}
 
@@ -47,8 +60,8 @@ func ExampleSplit() {
 	}
 	fmt.Println("On Unix:")
 	for _, p := range paths {
-		dir, file := filepath.Split(p)
-		fmt.Printf("input: %q\n\tdir: %q\n\tfile: %q\n", p, dir, file)
+		pair := path.Split(p, path.Unix)
+		fmt.Printf("input: %q\n\tdir: %q\n\tfile: %q\n", p, pair[0], pair[1])
 	}
 	// Output:
 	// On Unix:
@@ -68,12 +81,12 @@ func ExampleSplit() {
 
 func ExampleJoin() {
 	fmt.Println("On Unix:")
-	fmt.Println(filepath.Join("a", "b", "c"))
-	fmt.Println(filepath.Join("a", "b/c"))
-	fmt.Println(filepath.Join("a/b", "c"))
-	fmt.Println(filepath.Join("a/b", "/c"))
+	fmt.Println(path.Join([]string{"a", "b", "c"}, path.Unix))
+	fmt.Println(path.Join([]string{"a", "b/c"}, path.Unix))
+	fmt.Println(path.Join([]string{"a/b", "c"}, path.Unix))
+	fmt.Println(path.Join([]string{"a/b", "/c"}, path.Unix))
 
-	fmt.Println(filepath.Join("a/b", "../../../xyz"))
+	fmt.Println(path.Join([]string{"a/b", "../../../xyz"}, path.Unix))
 
 	// Output:
 	// On Unix:
@@ -86,10 +99,10 @@ func ExampleJoin() {
 
 func ExampleMatch() {
 	fmt.Println("On Unix:")
-	fmt.Println(filepath.Match("/home/catch/*", "/home/catch/foo"))
-	fmt.Println(filepath.Match("/home/catch/*", "/home/catch/foo/bar"))
-	fmt.Println(filepath.Match("/home/?opher", "/home/gopher"))
-	fmt.Println(filepath.Match("/home/\\*", "/home/*"))
+	fmt.Println(path.Match("/home/catch/*", "/home/catch/foo", path.Unix))
+	fmt.Println(path.Match("/home/catch/*", "/home/catch/foo/bar", path.Unix))
+	fmt.Println(path.Match("/home/?opher", "/home/gopher", path.Unix))
+	fmt.Println(path.Match("/home/\\*", "/home/*", path.Unix))
 
 	// Output:
 	// On Unix:
@@ -101,15 +114,15 @@ func ExampleMatch() {
 
 func ExampleBase() {
 	fmt.Println("On Unix:")
-	fmt.Println(filepath.Base("/foo/bar/baz.js"))
-	fmt.Println(filepath.Base("/foo/bar/baz"))
-	fmt.Println(filepath.Base("/foo/bar/baz/"))
-	fmt.Println(filepath.Base("dev.txt"))
-	fmt.Println(filepath.Base("../todo.txt"))
-	fmt.Println(filepath.Base(".."))
-	fmt.Println(filepath.Base("."))
-	fmt.Println(filepath.Base("/"))
-	fmt.Println(filepath.Base(""))
+	fmt.Println(path.Base("/foo/bar/baz.js", path.Unix))
+	fmt.Println(path.Base("/foo/bar/baz", path.Unix))
+	fmt.Println(path.Base("/foo/bar/baz/", path.Unix))
+	fmt.Println(path.Base("dev.txt", path.Unix))
+	fmt.Println(path.Base("../todo.txt", path.Unix))
+	fmt.Println(path.Base("..", path.Unix))
+	fmt.Println(path.Base(".", path.Unix))
+	fmt.Println(path.Base("/", path.Unix))
+	fmt.Println(path.Base("", path.Unix))
 
 	// Output:
 	// On Unix:
@@ -126,16 +139,16 @@ func ExampleBase() {
 
 func ExampleDir() {
 	fmt.Println("On Unix:")
-	fmt.Println(filepath.Dir("/foo/bar/baz.js"))
-	fmt.Println(filepath.Dir("/foo/bar/baz"))
-	fmt.Println(filepath.Dir("/foo/bar/baz/"))
-	fmt.Println(filepath.Dir("/dirty//path///"))
-	fmt.Println(filepath.Dir("dev.txt"))
-	fmt.Println(filepath.Dir("../todo.txt"))
-	fmt.Println(filepath.Dir(".."))
-	fmt.Println(filepath.Dir("."))
-	fmt.Println(filepath.Dir("/"))
-	fmt.Println(filepath.Dir(""))
+	fmt.Println(path.Dir("/foo/bar/baz.js", path.Unix))
+	fmt.Println(path.Dir("/foo/bar/baz", path.Unix))
+	fmt.Println(path.Dir("/foo/bar/baz/", path.Unix))
+	fmt.Println(path.Dir("/dirty//path///", path.Unix))
+	fmt.Println(path.Dir("dev.txt", path.Unix))
+	fmt.Println(path.Dir("../todo.txt", path.Unix))
+	fmt.Println(path.Dir("..", path.Unix))
+	fmt.Println(path.Dir(".", path.Unix))
+	fmt.Println(path.Dir("/", path.Unix))
+	fmt.Println(path.Dir("", path.Unix))
 
 	// Output:
 	// On Unix:
@@ -153,12 +166,12 @@ func ExampleDir() {
 
 func ExampleIsAbs() {
 	fmt.Println("On Unix:")
-	fmt.Println(filepath.IsAbs("/home/gopher"))
-	fmt.Println(filepath.IsAbs(".bashrc"))
-	fmt.Println(filepath.IsAbs(".."))
-	fmt.Println(filepath.IsAbs("."))
-	fmt.Println(filepath.IsAbs("/"))
-	fmt.Println(filepath.IsAbs(""))
+	fmt.Println(path.IsAbs("/home/gopher", path.Unix))
+	fmt.Println(path.IsAbs(".bashrc", path.Unix))
+	fmt.Println(path.IsAbs("..", path.Unix))
+	fmt.Println(path.IsAbs(".", path.Unix))
+	fmt.Println(path.IsAbs("/", path.Unix))
+	fmt.Println(path.IsAbs("", path.Unix))
 
 	// Output:
 	// On Unix:

pkg/path/testdata/example_test.go

@@ -1,18 +1,33 @@
+// Copyright 2020 CUE Authors
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//     http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
 // Copyright 2017 The Go Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style
 // license that can be found in the LICENSE file.
 
-package filepath_test
+package path_test
 
 import (
 	"fmt"
-	"path/filepath"
+
+	"cuelang.org/go/pkg/path"
 )
 
 func ExampleExt() {
-	fmt.Printf("No dots: %q\n", filepath.Ext("index"))
-	fmt.Printf("One dot: %q\n", filepath.Ext("index.js"))
-	fmt.Printf("Two dots: %q\n", filepath.Ext("main.test.js"))
+	fmt.Printf("No dots: %q\n", path.Ext("index", "unix"))
+	fmt.Printf("One dot: %q\n", path.Ext("index.js", "unix"))
+	fmt.Printf("Two dots: %q\n", path.Ext("main.test.js", "unix"))
 	// Output:
 	// No dots: ""
 	// One dot: ".js"