internal/core/adt: filter notifications

Unconditionally adding a node for notifications
is costly. "Popular" schema can easily get into
the thousands of notifications. As long as all
conjuncts are known, there is really no need to
register the schema for notification.

To detect this is straightforward: if all ancestors
have been processed, and the parent of
a schema has computed all tasks that can
compute field conjuncts, all conjuncts are known.

We also lower the trigger to include diffs
for notifications to 10 Notifications. This
adds a couple of files.

Issue #3334
Issue #2850

Signed-off-by: Marcel van Lohuizen <[email protected]>
Change-Id: Iee6f4342295d87ebfd5b8ac1a0a3e5f5f60f0d1b
Reviewed-on: https://review.gerrithub.io/c/cue-lang/cue/+/1218273
Unity-Result: CUE porcuepine <[email protected]>
Reviewed-by: Daniel Martí <[email protected]>
TryBot-Result: CUEcueckoo <[email protected]>

Author: mpvl

cue/testdata/basicrewrite/018_self-reference_cycles.txtar

@@ -146,15 +146,14 @@ Retain: 0
 Unifications: 47
 Conjuncts:    91
 Disjuncts:    10
-Notifications: 3
 
 CloseIDElems: 7
 NumCloseIDs: 10
 -- diff/-out/evalalpha/stats<==>+out/eval/stats --
 diff old new
 --- old
 +++ new
-@@ -1,9 +1,13 @@
+@@ -1,9 +1,12 @@
 -Leaks:  1
 -Freed:  57
 -Reused: 46
@@ -173,7 +172,6 @@ diff old new
 +Unifications: 47
 +Conjuncts:    91
 +Disjuncts:    10
-+Notifications: 3
 +
 +CloseIDElems: 7
 +NumCloseIDs: 10

cue/testdata/benchmarks/issue2176.txtar

@@ -67,15 +67,14 @@ Retain: 0
 Unifications: 375
 Conjuncts:    1332
 Disjuncts:    8
-Notifications: 35
 
 CloseIDElems: 5337
 NumCloseIDs: 535
 -- diff/-out/evalalpha/stats<==>+out/eval/stats --
 diff old new
 --- old
 +++ new
-@@ -1,12 +1,13 @@
+@@ -1,12 +1,12 @@
 -Leaks:  90
 -Freed:  684
 -Reused: 680
@@ -97,7 +96,6 @@ diff old new
 +Unifications: 375
 +Conjuncts:    1332
 +Disjuncts:    8
-+Notifications: 35
 +
 +CloseIDElems: 5337
 +NumCloseIDs: 535

cue/testdata/benchmarks/issue3334.txtar

@@ -52,15 +52,14 @@ Retain: 0
 Unifications: 452
 Conjuncts:    797
 Disjuncts:    310
-Notifications: 21
 
 CloseIDElems: 0
 NumCloseIDs: 21
 -- diff/-out/evalalpha/stats<==>+out/eval/stats --
 diff old new
 --- old
 +++ new
-@@ -1,9 +1,13 @@
+@@ -1,9 +1,12 @@
  Leaks:  0
 -Freed:  401
 -Reused: 388
@@ -78,7 +77,6 @@ diff old new
 +Unifications: 452
 +Conjuncts:    797
 +Disjuncts:    310
-+Notifications: 21
 +
 +CloseIDElems: 0
 +NumCloseIDs: 21

cue/testdata/benchmarks/issue3514.txtar

@@ -45,7 +45,7 @@ Retain: 0
 Unifications: 50
 Conjuncts:    7010
 Disjuncts:    2362
-Notifications: 2287
+Notifications: 2
 
 CloseIDElems: 35
 NumCloseIDs: 5733
@@ -72,7 +72,7 @@ diff old new
 +Unifications: 50
 +Conjuncts:    7010
 +Disjuncts:    2362
-+Notifications: 2287
++Notifications: 2
 +
 +CloseIDElems: 35
 +NumCloseIDs: 5733

cue/testdata/benchmarks/issue3517.txtar

@@ -63,15 +63,14 @@ Retain: 0
 Unifications: 45
 Conjuncts:    119
 Disjuncts:    0
-Notifications: 1
 
 CloseIDElems: 12
 NumCloseIDs: 13
 -- diff/-out/evalalpha/stats<==>+out/eval/stats --
 diff old new
 --- old
 +++ new
-@@ -1,9 +1,13 @@
+@@ -1,9 +1,12 @@
 -Leaks:  2
 -Freed:  49
 -Reused: 39
@@ -90,7 +89,6 @@ diff old new
 +Unifications: 45
 +Conjuncts:    119
 +Disjuncts:    0
-+Notifications: 1
 +
 +CloseIDElems: 12
 +NumCloseIDs: 13

cue/testdata/benchmarks/listdedup.txtar

@@ -42,7 +42,6 @@ Retain: 0
 Unifications: 33
 Conjuncts:    91
 Disjuncts:    24
-Notifications: 2
 
 CloseIDElems: 541
 NumCloseIDs: 22
@@ -467,7 +466,7 @@ diff old new
 diff old new
 --- old
 +++ new
-@@ -1,9 +1,13 @@
+@@ -1,9 +1,12 @@
  Leaks:  0
 -Freed:  24096
 -Reused: 24051
@@ -485,7 +484,6 @@ diff old new
 +Unifications: 33
 +Conjuncts:    91
 +Disjuncts:    24
-+Notifications: 2
 +
 +CloseIDElems: 541
 +NumCloseIDs: 22

cue/testdata/benchmarks/sharefg.txtar

@@ -119,15 +119,14 @@ Retain: 0
 Unifications: 452
 Conjuncts:    845
 Disjuncts:    0
-Notifications: 56
 
 CloseIDElems: 0
 NumCloseIDs: 238
 -- diff/-out/evalalpha/stats<==>+out/eval/stats --
 diff old new
 --- old
 +++ new
-@@ -1,9 +1,13 @@
+@@ -1,9 +1,12 @@
 -Leaks:  112
 -Freed:  340
 -Reused: 308
@@ -144,7 +143,6 @@ diff old new
 -Disjuncts:    720
 +Conjuncts:    845
 +Disjuncts:    0
-+Notifications: 56
 +
 +CloseIDElems: 0
 +NumCloseIDs: 238

cue/testdata/benchmarks/typocheck.txtar

@@ -30,15 +30,14 @@ Retain: 0
 Unifications: 700
 Conjuncts:    1302
 Disjuncts:    0
-Notifications: 3
 
 CloseIDElems: 42120
 NumCloseIDs: 212
 -- diff/-out/evalalpha/stats<==>+out/eval/stats --
 diff old new
 --- old
 +++ new
-@@ -1,12 +1,13 @@
+@@ -1,12 +1,12 @@
  Leaks:  0
  Freed:  700
 -Reused: 594
@@ -55,7 +54,6 @@ diff old new
 -CloseIDElems: 0
 -NumCloseIDs: 4
 +Disjuncts:    0
-+Notifications: 3
 +
 +CloseIDElems: 42120
 +NumCloseIDs: 212

cue/testdata/builtins/056_issue314.txtar

@@ -83,15 +83,14 @@ Retain: 0
 Unifications: 21
 Conjuncts:    24
 Disjuncts:    0
-Notifications: 1
 
 CloseIDElems: 6
 NumCloseIDs: 3
 -- diff/-out/evalalpha/stats<==>+out/eval/stats --
 diff old new
 --- old
 +++ new
-@@ -1,9 +1,13 @@
+@@ -1,9 +1,12 @@
  Leaks:  0
 -Freed:  45
 -Reused: 39
@@ -109,7 +108,6 @@ diff old new
 +Unifications: 21
 +Conjuncts:    24
 +Disjuncts:    0
-+Notifications: 1
 +
 +CloseIDElems: 6
 +NumCloseIDs: 3

cue/testdata/builtins/closed.txtar

@@ -101,15 +101,14 @@ Retain: 0
 Unifications: 183
 Conjuncts:    298
 Disjuncts:    6
-Notifications: 35
 
 CloseIDElems: 525
 NumCloseIDs: 88
 -- diff/-out/evalalpha/stats<==>+out/eval/stats --
 diff old new
 --- old
 +++ new
-@@ -1,9 +1,13 @@
+@@ -1,9 +1,12 @@
 -Leaks:  61
 -Freed:  214
 -Reused: 208
@@ -128,7 +127,6 @@ diff old new
 +Unifications: 183
 +Conjuncts:    298
 +Disjuncts:    6
-+Notifications: 35
 +
 +CloseIDElems: 525
 +NumCloseIDs: 88