internal/ci: place input parameters inside an #in struct

Otherwise, typos like #additionalCacheDirs go unnoticed
as they don't cause any typo checking errors.
At least this way, we can get typo checking within the #in struct.

Signed-off-by: Daniel Martí <[email protected]>
Change-Id: I608ad3b7a95519d2c5f05d368f5d9d6a4a9f6484
Reviewed-on: https://cue.gerrithub.io/c/cue-lang/cue/+/1219412
Reviewed-by: Paul Jolly <[email protected]>
Unity-Result: CUE porcuepine <[email protected]>
TryBot-Result: CUEcueckoo <[email protected]>

Author: mvdan

internal/ci/base/github.cue

@@ -171,9 +171,10 @@ curlGitHubAPI: {
 //
 // Note that `${NSC_CACHE_PATH}` (`/cache`) is always mounted as a cache volume.
 setupCaches: {
-	#additionalCaches: [...string] // with.cache
-
-	#additionalCachePaths: [...string] // with.path
+	#in: {
+		additionalCaches: [...string] // with.cache
+		additionalCachePaths: [...string] // with.path
+	}
 
 	[
 		githubactions.#Step & {
@@ -185,10 +186,10 @@ setupCaches: {
 			with: {
 				let cacheModes = list.Concat([[
 					"go",
-				], #additionalCaches])
+				], #in.additionalCaches])
 				let cachePaths = list.Concat([[
 					// nothing here for now.
-				], #additionalCachePaths])
+				], #in.additionalCachePaths])
 
 				if len(cacheModes) > 0 {
 					cache: strings.Join(cacheModes, "\n")
@@ -220,10 +221,10 @@ goChecks: githubactions.#Step & {
 }
 
 staticcheck: githubactions.#Step & {
-	#modfile: string | *"" // an optional -modfile flag to not use the main go.mod
+	#in: modfile: string | *"" // an optional -modfile flag to not use the main go.mod
 	let gotool = [
-		if #modfile != "" {
-			"go tool -modfile=\(#modfile)"
+		if #in.modfile != "" {
+			"go tool -modfile=\(#in.modfile)"
 		},
 		"go tool",
 	][0]

internal/ci/github/trybot.cue

@@ -157,7 +157,7 @@ workflows: trybot: _repo.bashWorkflow & {
 		},
 		// Note that we don't want tooling dependencies in the go.mod file,
 		// given how many downstreams rely on the cue module having few dependencies.
-		_repo.staticcheck & {#modfile: "internal/tools.mod"},
+		_repo.staticcheck & {#in: modfile: "internal/tools.mod"},
 	]
 
 	_checkTags: githubactions.#Step & {