internal/core/adt: do not repeat replaceIDs calls

getReqSets already calls replaceIDs on the current nodeContext.
checkTypos doesn't need to do it again.

For https://github.com/Caascad/unity-tests, which is still affected
by the slowness of the closedness algorithm, this brings another nice
chunk of savings:

               │    old     │                new                │
               │   sec/op   │   sec/op    vs base               │
    VetCaascad   8.148 ± 2%   5.539 ± 2%  -32.01% (p=0.002 n=6)

               │     old      │                new                 │
               │     B/op     │     B/op      vs base              │
    VetCaascad   3.640Gi ± 0%   3.316Gi ± 0%  -8.92% (p=0.002 n=6)

               │     old     │                new                │
               │  allocs/op  │  allocs/op   vs base              │
    VetCaascad   14.01M ± 0%   12.84M ± 0%  -8.34% (p=0.002 n=6)

Updates #3881.

Signed-off-by: Daniel Martí <[email protected]>
Change-Id: I332b03665c96dc3df329f92007c45b03a40b92b4
Reviewed-on: https://review.gerrithub.io/c/cue-lang/cue/+/1217194
TryBot-Result: CUEcueckoo <[email protected]>
Unity-Result: CUE porcuepine <[email protected]>
Reviewed-by: Marcel van Lohuizen <[email protected]>

Author: mvdan

cue/testdata/basicrewrite/018_self-reference_cycles.txtar

@@ -147,7 +147,7 @@ Unifications: 47
 Conjuncts:    91
 Disjuncts:    10
 
-CloseIDElems: 12
+CloseIDElems: 7
 NumCloseIDs: 10
 -- diff/-out/evalalpha/stats<==>+out/eval/stats --
 diff old new
@@ -173,7 +173,7 @@ diff old new
 +Conjuncts:    91
 +Disjuncts:    10
 +
-+CloseIDElems: 12
++CloseIDElems: 7
 +NumCloseIDs: 10
 -- out/eval/stats --
 Leaks:  1

cue/testdata/benchmarks/cycleshare.txtar

@@ -36,7 +36,7 @@ Unifications: 43
 Conjuncts:    70
 Disjuncts:    21
 
-CloseIDElems: 6
+CloseIDElems: 3
 NumCloseIDs: 1
 -- diff/-out/evalalpha/stats<==>+out/eval/stats --
 diff old new
@@ -62,7 +62,7 @@ diff old new
 +Conjuncts:    70
 +Disjuncts:    21
 +
-+CloseIDElems: 6
++CloseIDElems: 3
 +NumCloseIDs: 1
 -- out/eval/stats --
 Leaks:  8

cue/testdata/benchmarks/disjunctelim.txtar

@@ -50,7 +50,7 @@ Unifications: 22
 Conjuncts:    843
 Disjuncts:    618
 
-CloseIDElems: 54
+CloseIDElems: 42
 NumCloseIDs: 3
 -- diff/-out/evalalpha/stats<==>+out/eval/stats --
 diff old new
@@ -74,7 +74,7 @@ diff old new
 +Conjuncts:    843
 +Disjuncts:    618
 +
-+CloseIDElems: 54
++CloseIDElems: 42
 +NumCloseIDs: 3
 -- out/eval/stats --
 Leaks:  0

cue/testdata/benchmarks/inlinedisjunction.txtar

@@ -24,7 +24,7 @@ Unifications: 16
 Conjuncts:    113
 Disjuncts:    58
 
-CloseIDElems: 258
+CloseIDElems: 129
 NumCloseIDs: 23
 -- out/eval --
 (struct){
@@ -66,7 +66,7 @@ diff old new
 +Conjuncts:    113
 +Disjuncts:    58
 +
-+CloseIDElems: 258
++CloseIDElems: 129
 +NumCloseIDs: 23
 -- out/eval/stats --
 Leaks:  0

cue/testdata/benchmarks/issue1684.txtar

@@ -72,7 +72,7 @@ Unifications: 5541
 Conjuncts:    25871
 Disjuncts:    6534
 
-CloseIDElems: 41473
+CloseIDElems: 18527
 NumCloseIDs: 4115
 -- out/evalalpha --
 (struct){
@@ -159,7 +159,7 @@ diff old new
 +Conjuncts:    25871
 +Disjuncts:    6534
 +
-+CloseIDElems: 41473
++CloseIDElems: 18527
 +NumCloseIDs: 4115
 -- diff/-out/evalalpha<==>+out/eval --
 diff old new

cue/testdata/benchmarks/issue2176.txtar

@@ -68,7 +68,7 @@ Unifications: 377
 Conjuncts:    1333
 Disjuncts:    8
 
-CloseIDElems: 8382
+CloseIDElems: 5650
 NumCloseIDs: 535
 -- diff/-out/evalalpha/stats<==>+out/eval/stats --
 diff old new
@@ -97,7 +97,7 @@ diff old new
 +Conjuncts:    1333
 +Disjuncts:    8
 +
-+CloseIDElems: 8382
++CloseIDElems: 5650
 +NumCloseIDs: 535
 -- out/eval/stats --
 Leaks:  90

cue/testdata/benchmarks/issue3514.txtar

@@ -46,7 +46,7 @@ Unifications: 69
 Conjuncts:    7053
 Disjuncts:    2386
 
-CloseIDElems: 71
+CloseIDElems: 35
 NumCloseIDs: 5733
 -- diff/-out/evalalpha/stats<==>+out/eval/stats --
 diff old new
@@ -72,7 +72,7 @@ diff old new
 +Conjuncts:    7053
 +Disjuncts:    2386
 +
-+CloseIDElems: 71
++CloseIDElems: 35
 +NumCloseIDs: 5733
 -- out/eval/stats --
 Leaks:  27

cue/testdata/benchmarks/issue3517.txtar

@@ -64,7 +64,7 @@ Unifications: 49
 Conjuncts:    123
 Disjuncts:    0
 
-CloseIDElems: 20
+CloseIDElems: 12
 NumCloseIDs: 13
 -- diff/-out/evalalpha/stats<==>+out/eval/stats --
 diff old new
@@ -90,7 +90,7 @@ diff old new
 +Conjuncts:    123
 +Disjuncts:    0
 +
-+CloseIDElems: 20
++CloseIDElems: 12
 +NumCloseIDs: 13
 -- out/eval/stats --
 Leaks:  2

cue/testdata/benchmarks/listdedup.txtar

@@ -43,7 +43,7 @@ Unifications: 40
 Conjuncts:    98
 Disjuncts:    24
 
-CloseIDElems: 997
+CloseIDElems: 541
 NumCloseIDs: 22
 -- out/evalalpha --
 (struct){
@@ -486,7 +486,7 @@ diff old new
 +Conjuncts:    98
 +Disjuncts:    24
 +
-+CloseIDElems: 997
++CloseIDElems: 541
 +NumCloseIDs: 22
 -- out/eval/stats --
 Leaks:  0

cue/testdata/benchmarks/typocheck.txtar

@@ -31,7 +31,7 @@ Unifications: 703
 Conjuncts:    1305
 Disjuncts:    0
 
-CloseIDElems: 43723
+CloseIDElems: 42120
 NumCloseIDs: 212
 -- diff/-out/evalalpha/stats<==>+out/eval/stats --
 diff old new
@@ -60,7 +60,7 @@ diff old new
 +Conjuncts:    1305
 +Disjuncts:    0
 +
-+CloseIDElems: 43723
++CloseIDElems: 42120
 +NumCloseIDs: 212
 -- out/eval/stats --
 Leaks:  0