internal/ci/goreleaser: adjust after evalv3 fix for #3908

CI at master does a couple of extra steps, such as validating that
a dry-run of the release process works. However, the recent merge of
https://cuelang.org/cl/1214564 broke our `cue cmd release`
as ran by CI, with GITHUB_REF set by GitHub:

    $ GITHUB_REF=foo cue cmd release
    command.release.info.text: invalid string argument: invalid interpolation: unresolved disjunction "foo" | "refs/no_ref_kind/not_a_release" (type string):
        ./goreleaser_tool.cue:75:2
        ./goreleaser_tool.cue:22:23
        ./goreleaser_tool.cue:76:3
        ./goreleaser_tool.cue:76:9
        tool/cli:4:3

It turns out that the reason was our goreleaser_tool.cue was buggy:

    let _githubRef = env.GITHUB_REF | "refs/no_ref_kind/not_a_release"

When the GITHUB_REF env var is set to e.g. "foo", this should result in
the ambiguous value `"foo" | "refs/no_ref_kind/not_a_release"`,
and hence an error, just like CUE at master with evalv3 reports.
However, evalv2 happily resolves that to `"foo"`.

We can fix our CUE by selecting env.GITHUB_REF as the default,
ensuring that it has priority when it is set in the environment.

Also add a regression test to ensure that the ambiguous scenario
stays as an error on evalv3 and future evaluator versions.
We also show that it succeeds on evalv2, which is broken behavior.

While here, fix a goreleaser deprecation warning which begain in v2.6:
https://goreleaser.com/deprecations/#archivesformat_overridesformat

Signed-off-by: Daniel Martí <[email protected]>
Change-Id: I8a96b697820a607209e914eb48ee4f0e56b3a586
Reviewed-on: https://review.gerrithub.io/c/cue-lang/cue/+/1214619
TryBot-Result: CUEcueckoo <[email protected]>
Unity-Result: CUE porcuepine <[email protected]>
Reviewed-by: Matthew Sackman <[email protected]>

Author: mvdan

cmd/cue/cmd/testdata/script/cmd_env.txtar

@@ -2,6 +2,15 @@ env TESTNUM=10
 env MYTEXT=World
 exec cue cmd env
 cmp stdout cmd_env.out
+
+env CUE_EXPERIMENT=evalv3=0
+exec cue cmd issue3908
+stdout '^World$'
+
+env CUE_EXPERIMENT=evalv3=1
+! exec cue cmd issue3908
+stderr 'issue3908.print.text: .*non-concrete value string'
+
 -- cmd_env.out --
 Hello World!
 -- task_tool.cue --
@@ -21,3 +30,12 @@ command: env: {
 		text: "Hello \(env.MYTEXT)!"
 	}
 }
+
+// Should fail when the MYTEXT env var is set, but evalv2 did not fail.
+command: issue3908: {
+	env: os.Environ
+	_mytext: env.MYTEXT | "fallback"
+	print: cli.Print & {
+		text: _mytext
+	}
+}

internal/ci/goreleaser/goreleaser.cue

@@ -53,8 +53,8 @@ config: {
 			"doc/ref/spec.md",
 		]
 		format_overrides: [{
-			goos:   "windows"
-			format: "zip"
+			goos:    "windows"
+			formats: ["zip"]
 		}]
 	}]
 	release: {

internal/ci/goreleaser/goreleaser_tool.cue

@@ -18,7 +18,7 @@ command: release: {
 
 	let _env = env
 
-	let _githubRef = env.GITHUB_REF | "refs/no_ref_kind/not_a_release" // filled when running in CI
+	let _githubRef = *env.GITHUB_REF | "refs/no_ref_kind/not_a_release" // filled when running in CI
 	let _githubRefName = path.Base(_githubRef)
 
 	tempDir: file.MkdirTemp & {