internal/core/adt: consider required fields for final values in Equal

mpvl · mpvl · commit 64d57890f3d4 · 2025-06-19T16:47:35.000Z
This corresponds to an error being generated when exporting a value. Issue #2583 Signed-off-by: Marcel van Lohuizen <mpvl@gmail.com> Change-Id: I0fe3cf1a7ccb4f6ef94889f592453c7d42ad0131 Reviewed-on: https://review.gerrithub.io/c/cue-lang/cue/+/1217009 Reviewed-by: Roger Peppe <rogpeppe@gmail.com> TryBot-Result: CUEcueckoo <cueckoo@cuelang.org> Unity-Result: CUE porcuepine <cue.porcuepine@gmail.com>
diff --git a/internal/core/adt/equality.go b/internal/core/adt/equality.go
@@ -75,7 +75,7 @@ func equalVertex(ctx *OpContext, x *Vertex, v Value, flags Flag) bool {
 		return false
 	}
 
-	maxArcType := ArcMember
+	maxArcType := ArcRequired
 	if flags&CheckStructural != 0 {
 		// Do not ignore optional fields
 		// TODO(required): consider making this unconditional

Original file line number	Diff line number	Diff line change
`@@ -75,7 +75,7 @@ func equalVertex(ctx OpContext, x Vertex, v Value, flags Flag) bool {`
`75`	`75`	`return false`
`76`	`76`	`}`
`77`	`77`
`78`		`- maxArcType := ArcMember`
	`78`	`+ maxArcType := ArcRequired`
`79`	`79`	`if flags&CheckStructural != 0 {`
`80`	`80`	`// Do not ignore optional fields`
`81`	`81`	`// TODO(required): consider making this unconditional`