internal/gopls: remove unnecessary old command alias

At some point in the past, gopls changed the name of its "remote"
command from "inspect". We don't need to support the old alias.

Signed-off-by: Matthew Sackman <[email protected]>
Change-Id: I827ac724a7bf9ab24e5bc1aea570af2630a64030
Reviewed-on: https://review.gerrithub.io/c/cue-lang/cue/+/1218087
Reviewed-by: Daniel Martí <[email protected]>
TryBot-Result: CUEcueckoo <[email protected]>
Unity-Result: CUE porcuepine <[email protected]>

Author: cuematthew

internal/golangorgx/gopls/cmd/cmd.go

@@ -266,8 +266,7 @@ func (app *Application) internalCommands() []tool.Application {
 func (app *Application) featureCommands() []tool.Application {
 	return []tool.Application{
 		&format{app: app},
-		newRemote(app, ""),
-		newRemote(app, "inspect"),
+		newRemote(app),
 	}
 }
 

internal/golangorgx/gopls/cmd/remote.go

@@ -20,41 +20,23 @@ import (
 type remote struct {
 	app *Application
 	subcommands
-
-	// For backward compatibility, allow aliasing this command (it was previously
-	// called 'inspect').
-	//
-	// TODO(rFindley): delete this after allowing some transition time in case
-	//                 there were any users of 'inspect' (I suspect not).
-	alias string
 }
 
-func newRemote(app *Application, alias string) *remote {
+func newRemote(app *Application) *remote {
 	return &remote{
 		app: app,
 		subcommands: subcommands{
 			&listSessions{app: app},
 			&startDebugging{app: app},
 		},
-		alias: alias,
 	}
 }
 
-func (r *remote) Name() string {
-	if r.alias != "" {
-		return r.alias
-	}
-	return "remote"
-}
-
+func (r *remote) Name() string   { return "remote" }
 func (r *remote) Parent() string { return r.app.Name() }
 
 func (r *remote) ShortHelp() string {
-	short := "interact with the cuelsp daemon"
-	if r.alias != "" {
-		short += " (deprecated: use 'remote')"
-	}
-	return short
+	return "interact with the cuelsp daemon"
 }
 
 // listSessions is an inspect subcommand to list current sessions.