Skip to content

Commit 3260084

Browse files
committed
cmd/cue: use fewer go/packages Need bits in get go
NeedFiles and NeedTypesSizes are unnecessary. Most of the current slowness is due to NeedSyntax and NeedTypes being combined with NeedDeps, meaning that we must parse and typecheck all transitive dependencies - but `get go` needs this as it recurses into all dependencies by design. Signed-off-by: Daniel Martí <[email protected]> Change-Id: I5e6f4d7d9771c75f2f1317874c91b8072376abb9 Reviewed-on: https://review.gerrithub.io/c/cue-lang/cue/+/1198962 Unity-Result: CUE porcuepine <[email protected]> Reviewed-by: Roger Peppe <[email protected]> TryBot-Result: CUEcueckoo <[email protected]>
1 parent 30a5c79 commit 3260084

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed

cmd/cue/cmd/get_go.go

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -370,10 +370,9 @@ func extract(cmd *Command, args []string) error {
370370
root := binst.Root
371371

372372
cfg := &packages.Config{
373-
Mode: packages.NeedName | packages.NeedFiles | packages.NeedCompiledGoFiles |
374-
packages.NeedImports | packages.NeedTypes | packages.NeedTypesSizes |
375-
packages.NeedSyntax | packages.NeedTypesInfo | packages.NeedDeps |
376-
packages.NeedModule,
373+
Mode: packages.NeedName | packages.NeedCompiledGoFiles |
374+
packages.NeedImports | packages.NeedDeps | packages.NeedTypes |
375+
packages.NeedSyntax | packages.NeedTypesInfo | packages.NeedModule,
377376
}
378377
pkgs, err := packages.Load(cfg, args...)
379378
if err != nil {

0 commit comments

Comments
 (0)