internal/diff: use compact printing mode

mpvl · mpvl · commit 29dd2503becc · 2020-07-26T09:34:41.000Z
The default Syntax printing mode is not suitable. We should print evaluated values. Change-Id: I810b531f5898fcca049ac8943c5492e558f89ee5 Reviewed-on: https://cue-review.googlesource.com/c/cue/+/6660 Reviewed-by: CUE cueckoo <cueckoo@gmail.com> Reviewed-by: Marcel van Lohuizen <mpvl@golang.org>
diff --git a/internal/diff/print.go b/internal/diff/print.go
@@ -19,7 +19,6 @@ import (
 	"io"
 
 	"cuelang.org/go/cue/errors"
-	"cuelang.org/go/cue/format"
 	"cuelang.org/go/internal/legacy/cue"
 )
 
@@ -195,8 +194,8 @@ func (p *printer) printSkipped(n int) {
 
 func (p *printer) printValue(v cue.Value) {
 	// TODO: have indent option.
-	b, _ := format.Node(v.Syntax())
-	p.write(b)
+	s := fmt.Sprintf("%-v", v)
+	io.WriteString(p, s)
 }
 
 func (p *printer) printFieldRun(es *EditScript, start, end int) {

Original file line number	Diff line number	Diff line change
`@@ -19,7 +19,6 @@ import (`
`19`	`19`	`"io"`
`20`	`20`
`21`	`21`	`"cuelang.org/go/cue/errors"`
`22`		`- "cuelang.org/go/cue/format"`
`23`	`22`	`"cuelang.org/go/internal/legacy/cue"`
`24`	`23`	`)`
`25`	`24`
`@@ -195,8 +194,8 @@ func (p *printer) printSkipped(n int) {`
`195`	`194`
`196`	`195`	`func (p *printer) printValue(v cue.Value) {`
`197`	`196`	`// TODO: have indent option.`
`198`		`- b, _ := format.Node(v.Syntax())`
`199`		`- p.write(b)`
	`197`	`+ s := fmt.Sprintf("%-v", v)`
	`198`	`+ io.WriteString(p, s)`
`200`	`199`	`}`
`201`	`200`
`202`	`201`	`func (p printer) printFieldRun(es EditScript, start, end int) {`